Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add triagebot mentions entry for simd intrinsics #119123

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Add triagebot mentions entry for simd intrinsics #119123

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4369a78
Add triagebot mentions entry for simd intrinsics
bjorn3 Dec 19, 2023
adb6e1b
Update triagebot.toml
bjorn3 Dec 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions triagebot.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,13 @@ cc = ["@Nadrieril"]
message = "Some changes might have occurred in exhaustiveness checking"
cc = ["@Nadrieril"]

[mentions."library/core/src/intrinsics/simd.rs"]
message = """
Some changes occurred to the platform-builtins intrinsics. Make sure all
codegen backends as well as portable-simd get adapted for the changes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe phrase this so people creating PRs aren't under the impression that they have to update every backend by themselves? iirc gcc and cranelift aren't supposed to block PRs...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think we should update the text here, or make a T-compiler decision if we do want to block PRs. My guess is that we're not ready to block on making the backends work yet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

"""
cc = ["@antoyo", "@GuillaumeGomez", "@bjorn3", "@calebzulawski", "@programmerjake"]

[mentions."library/portable-simd"]
message = """
Portable SIMD is developed in its own repository. If possible, consider \
Expand Down