Skip to content

resolve: Feed visibilities for unresolved trait impl items #119134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2023
Merged

resolve: Feed visibilities for unresolved trait impl items #119134

merged 1 commit into from
Dec 20, 2023

Conversation

petrochenkov
Copy link
Contributor

Fixes #119073

@rustbot
Copy link
Collaborator

rustbot commented Dec 19, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 19, 2023
@petrochenkov petrochenkov mentioned this pull request Dec 19, 2023
Closed
@compiler-errors
Copy link
Member

r? compiler-errors @bors r+

@bors
Copy link
Collaborator

bors commented Dec 19, 2023

📌 Commit 7571f6f has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned TaKO8Ki Dec 19, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 19, 2023
@compiler-errors compiler-errors mentioned this pull request Dec 19, 2023
Closed
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Dec 19, 2023
@compiler-errors
Rollup merge of rust-lang#119134 - petrochenkov:feedvis2, r=compiler-…
41228d5 
…errors

resolve: Feed visibilities for unresolved trait impl items

Fixes rust-lang#119073
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 19, 2023
@bors
Auto merge of rust-lang#119143 - compiler-errors:rollup-vps74yb, r=co…
29fdb02 
…mpiler-errors

Rollup of 7 pull requests

Successful merges:

 - rust-lang#118691 (Add check for possible CStr literals in pre-2021)
 - rust-lang#118973 (rustc_codegen_ssa: Don't drop `IncorrectCguReuseType` , make `rustc_expected_cgu_reuse` attr work)
 - rust-lang#119071 (-Znext-solver: adapt overflow rules to avoid breakage)
 - rust-lang#119089 (effects: fix a comment)
 - rust-lang#119096 (Yeet unnecessary param envs)
 - rust-lang#119118 (Fix arm64e-apple-ios target)
 - rust-lang#119134 (resolve: Feed visibilities for unresolved trait impl items)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2023
@bors
Auto merge of rust-lang#119143 - compiler-errors:rollup-vps74yb, r=co…
9d12984 
…mpiler-errors

Rollup of 7 pull requests

Successful merges:

 - rust-lang#118691 (Add check for possible CStr literals in pre-2021)
 - rust-lang#118973 (rustc_codegen_ssa: Don't drop `IncorrectCguReuseType` , make `rustc_expected_cgu_reuse` attr work)
 - rust-lang#119071 (-Znext-solver: adapt overflow rules to avoid breakage)
 - rust-lang#119089 (effects: fix a comment)
 - rust-lang#119096 (Yeet unnecessary param envs)
 - rust-lang#119118 (Fix arm64e-apple-ios target)
 - rust-lang#119134 (resolve: Feed visibilities for unresolved trait impl items)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Dec 20, 2023

⌛ Testing commit 7571f6f with merge f9d52dc...

@bors
Copy link
Collaborator

bors commented Dec 20, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing f9d52dc to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 20, 2023
@bors bors merged commit f9d52dc into rust-lang:master Dec 20, 2023
@rustbot rustbot added this to the 1.76.0 milestone Dec 20, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f9d52dc): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.2% [-0.2%, -0.1%] 2
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.7% [2.6%, 2.8%] 3
Improvements ✅
(primary)		 -1.1% [-1.9%, -0.4%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.1% [-1.9%, -0.4%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.5% [0.5%, 0.5%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.6% [-3.9%, -0.4%] 3
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.1% [-3.9%, 0.5%] 4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.401s -> 673.565s (-0.12%)
Artifact size: 312.84 MiB -> 312.83 MiB (-0.00%)

@petrochenkov petrochenkov deleted the feedvis2 branch February 22, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
query feeding
Status: Done
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.

ICE: privacy: assertion failed: AssocFn == Closure
6 participants
@petrochenkov @rustbot @compiler-errors @bors @rust-timer @TaKO8Ki