Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverage: Check for async fn explicitly, without needing a heuristic #119155

Merged
merged 3 commits into from
Dec 20, 2023
Merged

coverage: Check for async fn explicitly, without needing a heuristic #119155

merged 3 commits into from
Dec 20, 2023

Commits on Dec 20, 2023

  1. coverage: Add a test for async blocks 

    We have coverage tests that use async functions, but none that use async
blocks.
    @Zalathar
    Zalathar committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    4ae7920 View commit details
    Browse the repository at this point in the history

  2. coverage: Pass around &ExtractedHirInfo instead of individual fields 

    This reduces the risk of mixing up `fn_source_span` and `body_span`, and makes
it easier to pass along additional fields as needed.
    @Zalathar
    Zalathar committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    2a0290a View commit details
    Browse the repository at this point in the history

  3. coverage: Check for async fn explicitly, without needing a heuristic 

    The old code used a heuristic to detect async functions and adjust their
coverage spans to produce better output. But there's no need to resort to a
heuristic when we can just check whether the current function is actually an
`async fn`.
    @Zalathar
    Zalathar committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    cf6dc7a View commit details
    Browse the repository at this point in the history