Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some comments #119368

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Fix some comments #119368

merged 1 commit into from
Dec 28, 2023

Conversation

cuishuang
Copy link
Contributor

No description provided.

Signed-off-by: cuishuang <imcusg@gmail.com>
@rustbot
Copy link
Collaborator

rustbot commented Dec 28, 2023

r? @WaffleLapkin

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 28, 2023
@rustbot
Copy link
Collaborator

rustbot commented Dec 28, 2023

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@WaffleLapkin
Copy link
Member

@bors r+ rollup=always

@bors
Copy link
Contributor

bors commented Dec 28, 2023

📌 Commit 1adf0c1 has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2023
@bors
Copy link
Contributor

bors commented Dec 28, 2023

⌛ Testing commit 1adf0c1 with merge f4d794e...

@bors
Copy link
Contributor

bors commented Dec 28, 2023

☀️ Test successful - checks-actions
Approved by: WaffleLapkin
Pushing f4d794e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 28, 2023
@bors bors merged commit f4d794e into rust-lang:master Dec 28, 2023
12 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Dec 28, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f4d794e): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.4% [-0.4%, -0.4%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.7% [1.2%, 2.3%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.3% [-4.1%, -2.4%] 2
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.6% [-0.8%, -0.5%] 3
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.6% [-0.8%, -0.5%] 3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.159s -> 671.862s (0.10%)
Artifact size: 312.29 MiB -> 312.35 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants