Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make ClosureArgsParts and CoroutineArgsParts not generic #119392

Merged
merged 1 commit into from
Dec 29, 2023
Merged

make ClosureArgsParts and CoroutineArgsParts not generic #119392

merged 1 commit into from
Dec 29, 2023

Conversation

compiler-errors
Copy link
Member

I hope a few extra calls to expect_ty will not affect perf...

@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rustbot
Copy link
Collaborator

rustbot commented Dec 28, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 28, 2023
@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 28, 2023
@bors
Copy link
Contributor

bors commented Dec 28, 2023

⌛ Trying commit 2b69399 with merge e5644f7...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 28, 2023
@bors
Auto merge of rust-lang#119392 - compiler-errors:args-parts, r=<try>
e5644f7 
make `ClosureArgsParts` and `CoroutineArgsParts` not generic

I hope a few extra calls to `expect_ty` will not affect perf...
Noratrieb
Noratrieb approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@Noratrieb Noratrieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me if perf is happy

@bors
Copy link
Contributor

bors commented Dec 28, 2023

☀️ Try build successful - checks-actions
Build commit: e5644f7 (e5644f73e9ac825f60a6985faabbddd4a94d6bed)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e5644f7): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 5.4% [5.4%, 5.4%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.476s -> 671.976s (-0.07%)
Artifact size: 312.31 MiB -> 312.32 MiB (0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 29, 2023
@compiler-errors
Copy link
Member Author

@bors r=Nilstrieb

@bors
Copy link
Contributor

bors commented Dec 29, 2023

📌 Commit 2b69399 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2023
@bors
Copy link
Contributor

bors commented Dec 29, 2023

⌛ Testing commit 2b69399 with merge 95613d1...

@bors
Copy link
Contributor

bors commented Dec 29, 2023

☀️ Test successful - checks-actions
Approved by: Nilstrieb
Pushing 95613d1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 29, 2023
@bors bors merged commit 95613d1 into rust-lang:master Dec 29, 2023
12 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Dec 29, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (95613d1): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.7% [0.7%, 0.7%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.7% [0.7%, 0.7%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.668s -> 672.269s (0.39%)
Artifact size: 312.30 MiB -> 312.29 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noratrieb Noratrieb Noratrieb approved these changes

Assignees

@TaKO8Ki TaKO8Ki

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.
6 participants
@compiler-errors @rustbot @rust-timer @bors @Noratrieb @TaKO8Ki