Fix clippy::correctness in the library
#119449
Conversation
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Noratrieb
force-pushed
the
library-clippy
branch
from
a203a97 to
4f25b47
Compare
|
Hello Libs team! We want to enable clippy::correctness in CI because this catches bugs (and would have caught at least one bug before) (rust-lang/compiler-team#709). The easiest way to enforce is is to just pass the flag in CI, which also affects the library. This requires a few fixes seen here and of course the commitment of the libs team to continue working with it. Given that correctness has a very low false positive rate, this seems unlikely to cause problems (of course there are some funny false positives, like suggesting using is_nan in the implementation of is_nan). |
Noratrieb
added
the
I-libs-nominated
|
We discussed this in the libs meeting and we have no objections to enabling clippy lints for the standard library. We can always revert later if this turns out to cause issues. |
Amanieu
removed
the
I-libs-nominated
|
Sounds good! Would appreciate a review :) |
| @@ -211,6 +211,8 @@ | |||
| #![cfg_attr(not(target_has_atomic_load_store = "8"), allow(dead_code))] | |||
| #![cfg_attr(not(target_has_atomic_load_store = "8"), allow(unused_imports))] | |||
| #![rustc_diagnostic_item = "atomic_mod"] | |||
| // AtomicPtr intrinsics are unsafe and take pointers, but do not dereference them. | |||
| #![allow(clippy::not_unsafe_ptr_arg_deref)] | |||
There was a problem hiding this comment.
Don't these call intrinsics which are themselves unsafe functions?
There was a problem hiding this comment.
Yes, they are unsafe, which is what clippy is concerned about. I elaborated the comment to explain what exactly is happening.
Noratrieb
force-pushed
the
library-clippy
branch
from
4f25b47 to
e55716e
Compare
|
r? libs |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#117740 (Add some links and minor explanatory comments to `std::fmt`) - rust-lang#118307 (Remove an unneeded helper from the tuple library code) - rust-lang#119242 (Suggest less bug-prone construction of Duration in docs) - rust-lang#119449 (Fix `clippy::correctness` in the library) - rust-lang#120307 (core: add Duration constructors) - rust-lang#120459 (Document various I/O descriptor/handle conversions) - rust-lang#120729 (Update mdbook to 0.4.37) - rust-lang#120763 (Suggest pattern tests when modifying exhaustiveness) - rust-lang#120906 (Remove myself from some review rotations) - rust-lang#120916 (Subtree update of ` rust-analyzer`) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#117740 (Add some links and minor explanatory comments to `std::fmt`) - rust-lang#118307 (Remove an unneeded helper from the tuple library code) - rust-lang#119242 (Suggest less bug-prone construction of Duration in docs) - rust-lang#119449 (Fix `clippy::correctness` in the library) - rust-lang#120307 (core: add Duration constructors) - rust-lang#120459 (Document various I/O descriptor/handle conversions) - rust-lang#120729 (Update mdbook to 0.4.37) - rust-lang#120763 (Suggest pattern tests when modifying exhaustiveness) - rust-lang#120906 (Remove myself from some review rotations) - rust-lang#120916 (Subtree update of ` rust-analyzer`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#119449 - Nilstrieb:library-clippy, r=cuviper Fix `clippy::correctness` in the library needs rust-lang/backtrace-rs#579 to be complete for rust-lang/compiler-team#709
needs rust-lang/backtrace-rs#579 to be complete
for rust-lang/compiler-team#709