Improve let_underscore_lock
#119710
Merged
Improve let_underscore_lock
#119710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @TaKO8Ki (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Noratrieb
force-pushed
the
let-_-=-oops
branch
from
478b5b4
to
c0f2ef5
Compare
This comment has been minimized.
This comment has been minimized.
Noratrieb
force-pushed
the
let-_-=-oops
branch
from
c0f2ef5
to
d148e42
Compare
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #119754) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@rustbot author |
rustbot
added
S-waiting-on-author
Noratrieb
force-pushed
the
let-_-=-oops
branch
from
d148e42
to
f4f3e6b
Compare
This comment has been minimized.
This comment has been minimized.
- lint if the lock was in a nested pattern - lint if the lock is inside a `Result<Lock, _>`
Noratrieb
force-pushed
the
let-_-=-oops
branch
from
f4f3e6b
to
a04ac49
Compare
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
Noratrieb
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 22, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#118714 ( Explanation that fields are being used when deriving `(Partial)Ord` on enums) - rust-lang#119710 (Improve `let_underscore_lock`) - rust-lang#119726 (Tweak Library Integer Division Docs) - rust-lang#119746 (rustdoc: hide modals when resizing the sidebar) - rust-lang#119986 (Fix error counting) - rust-lang#120194 (Shorten `#[must_use]` Diagnostic Message for `Option::is_none`) - rust-lang#120200 (Correct the anchor of an URL in an error message) - rust-lang#120203 (Replace `#!/bin/bash` with `#!/usr/bin/env bash` in rust-installer tests) - rust-lang#120212 (Give nnethercote more reviews) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 22, 2024
Rollup merge of rust-lang#119710 - Nilstrieb:let-_-=-oops, r=TaKO8Ki Improve `let_underscore_lock` - lint if the lock was in a nested pattern - lint if the lock is inside a `Result<Lock, _>` addresses rust-lang#119704 (comment)
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 25, 2024
Improve `let_underscore_lock` - lint if the lock was in a nested pattern - lint if the lock is inside a `Result<Lock, _>` addresses rust-lang#119704 (comment)
Akida31
added a commit
to Akida31/swww
that referenced
this pull request
Feb 9, 2024
[Recently][1] the [fix_underscore_lock][2] lint was improved and throws now (as of the upcoming rust 1.77) an error. Therefore I created separate methods for locking only `WallpaperInner`. An alternative could be that the `_` is converted to `_temp` and then the next statement could be `drop(_temp)` to stay with the current behaviour but silence the lint. [1]: rust-lang/rust#119710 [2]: https://doc.rust-lang.org/beta/nightly-rustc/rustc_lint/let_underscore/static.LET_UNDERSCORE_LOCK.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result<Lock, _>addresses #119704 (comment)