Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make (A)Rc/Weak allocator_api APIs more consistent #119761

Closed
wants to merge 6 commits into from
Closed

Make (A)Rc/Weak allocator_api APIs more consistent #119761

wants to merge 6 commits into from

Commits on Apr 29, 2024

  1. Make Rc allocator_api APIs more consistent. 

    * Add `into_raw_with_allocator` on `Rc`/`Weak`
* Remove `where A: Clone` from `Rc::assume_init`s, `Rc::unwrap_or_clone`, and `Rc::downcast(_unchecked)`
* Add `fn allocator(&self)` to `Rc`/`Weak` for all `T: ?Sized`
* Make `TryFrom<Rc<[T]>> for Rc<[T; N]>` allocator-aware
    @zachs18
    zachs18 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    f05b63b View commit details
    Browse the repository at this point in the history

  2. make internal_into_inner_with_allocator an associated fn to prevent n… 

    …ame collisions
    @zachs18
    zachs18 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    f9d7307 View commit details
    Browse the repository at this point in the history

  3. Move Arc::allocator to T: ?Sized

    @zachs18
    zachs18 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    a2002ec View commit details
    Browse the repository at this point in the history

  4. Add {Arc,Weak}::into_raw_with_allocator

    @zachs18
    zachs18 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    052a140 View commit details
    Browse the repository at this point in the history

  5. Add fn sync::Weak::allocator, remove A: Clone bound on Arc::unwrap_or… 

    …_clone and From<Vec<T, A>> for Arc<[T], A>
    @zachs18
    zachs18 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    f23292a View commit details
    Browse the repository at this point in the history

  6. add (private) Rc::into_inner_with_allocator, and use it where Arc does

    @zachs18
    zachs18 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    9f3dc91 View commit details
    Browse the repository at this point in the history