Skip to content

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Jan 10, 2024

Fixes #118867.
Fixes #119160.
Fixes #119179.

r? @cuviper

@rustbot
Copy link
Collaborator

rustbot commented Jan 10, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2024
@nikic nikic added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 10, 2024
@cuviper
Copy link
Member

cuviper commented Jan 10, 2024

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Jan 10, 2024

📌 Commit 9ff3083 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2024
@apiraino
Copy link
Contributor

Beta backport approved after merge as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 11, 2024
@bors
Copy link
Collaborator

bors commented Jan 11, 2024

⌛ Testing commit 9ff3083 with merge 062e7c6...

@bors
Copy link
Collaborator

bors commented Jan 11, 2024

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 062e7c6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 11, 2024
@bors bors merged commit 062e7c6 into rust-lang:master Jan 11, 2024
@rustbot rustbot added this to the 1.77.0 milestone Jan 11, 2024
@cuviper cuviper mentioned this pull request Jan 11, 2024
@cuviper cuviper modified the milestones: 1.77.0, 1.76.0 Jan 11, 2024
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 11, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (062e7c6): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.3% [1.3%, 1.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.4% [0.4%, 0.4%] 1
Regressions ❌
(secondary)
1.3% [1.3%, 1.3%] 2
Improvements ✅
(primary)
-0.4% [-0.4%, -0.4%] 1
Improvements ✅
(secondary)
-2.9% [-3.9%, -2.0%] 2
All ❌✅ (primary) -0.0% [-0.4%, 0.4%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.5% [-0.5%, -0.5%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.5% [-0.5%, -0.5%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 665.325s -> 665.796s (0.07%)
Artifact size: 308.34 MiB -> 308.37 MiB (0.01%)

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 11, 2024
[beta] backports

- mir-opt and custom target fixes rust-lang#119619
- Update LLVM submodule rust-lang#119802

r? ghost
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 12, 2024
[beta] backports

- mir-opt and custom target fixes rust-lang#119619
- Update LLVM submodule rust-lang#119802

r? ghost
NickeZ added a commit to NickeZ/bitbox02-firmware that referenced this pull request Jun 17, 2025
The fix for this bug was merged in 1.76 and we use a more recent
compiler.

rust-lang/rust#119802
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
6 participants