-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved collapse_debuginfo attribute, added command-line flag #119828
Merged
bors
merged 1 commit into
rust-lang:master
from
azhogin:azhogin/collapse_debuginfo_improved_attr
Jan 19, 2024
Merged
Improved collapse_debuginfo attribute, added command-line flag #119828
bors
merged 1 commit into
rust-lang:master
from
azhogin:azhogin/collapse_debuginfo_improved_attr
Jan 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jan 10, 2024
Marking as
S-waiting-on-author
|
rustbot
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jan 10, 2024
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/collapse_debuginfo_improved_attr
branch
from
January 11, 2024 06:24
0d05bf8
to
f3adf78
Compare
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/collapse_debuginfo_improved_attr
branch
from
January 11, 2024 06:44
f3adf78
to
6e21180
Compare
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/collapse_debuginfo_improved_attr
branch
from
January 11, 2024 14:59
6e21180
to
80619bc
Compare
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/collapse_debuginfo_improved_attr
branch
3 times, most recently
from
January 14, 2024 18:55
48a832c
to
2065508
Compare
azhogin
changed the title
Improved collapse_debuginfo attribute, added command-line flag (WIP)
Improved collapse_debuginfo attribute, added command-line flag
Jan 14, 2024
@rustbot review |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jan 14, 2024
tests/debuginfo/collapse-debuginfo-external-flag-overriden-by-attr.rs
Outdated
Show resolved
Hide resolved
petrochenkov
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jan 15, 2024
This comment was marked as resolved.
This comment was marked as resolved.
azhogin
force-pushed
the
azhogin/collapse_debuginfo_improved_attr
branch
from
January 16, 2024 15:38
2065508
to
0743f9c
Compare
azhogin
force-pushed
the
azhogin/collapse_debuginfo_improved_attr
branch
from
January 16, 2024 18:05
0743f9c
to
150d59c
Compare
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/collapse_debuginfo_improved_attr
branch
from
January 16, 2024 19:27
150d59c
to
6dddef7
Compare
azhogin
force-pushed
the
azhogin/collapse_debuginfo_improved_attr
branch
from
January 17, 2024 16:18
6dddef7
to
8507f51
Compare
Looks ready and CI is green. |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jan 17, 2024
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jan 17, 2024
…_improved_attr, r=petrochenkov Improved collapse_debuginfo attribute, added command-line flag Improved attribute collapse_debuginfo with variants: `#[collapse_debuginfo=(no|external|yes)]`. Added command-line flag for default behaviour. Work-in-progress: will add more tests. cc rust-lang#100758
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 18, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#119582 (bootstrap: handle vendored sources when remapping crate paths) - rust-lang#119730 (docs: fix typos) - rust-lang#119828 (Improved collapse_debuginfo attribute, added command-line flag) - rust-lang#119869 (replace `track_errors` usages with bubbling up `ErrorGuaranteed`) - rust-lang#120037 (Remove `next_root_ty_var`) - rust-lang#120094 (tests/ui/asm/inline-syntax: adapt for LLVM 18) - rust-lang#120096 (Set RUSTC_BOOTSTRAP=1 consistently) - rust-lang#120101 (change `.unwrap()` to `?` on write where `fmt::Result` is returned) - rust-lang#120102 (Fix typo in munmap_partial.rs) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 19, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#119582 (bootstrap: handle vendored sources when remapping crate paths) - rust-lang#119730 (docs: fix typos) - rust-lang#119828 (Improved collapse_debuginfo attribute, added command-line flag) - rust-lang#119869 (replace `track_errors` usages with bubbling up `ErrorGuaranteed`) - rust-lang#120037 (Remove `next_root_ty_var`) - rust-lang#120094 (tests/ui/asm/inline-syntax: adapt for LLVM 18) - rust-lang#120096 (Set RUSTC_BOOTSTRAP=1 consistently) - rust-lang#120101 (change `.unwrap()` to `?` on write where `fmt::Result` is returned) - rust-lang#120102 (Fix typo in munmap_partial.rs) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 19, 2024
Rollup merge of rust-lang#119828 - azhogin:azhogin/collapse_debuginfo_improved_attr, r=petrochenkov Improved collapse_debuginfo attribute, added command-line flag Improved attribute collapse_debuginfo with variants: `#[collapse_debuginfo=(no|external|yes)]`. Added command-line flag for default behaviour. Work-in-progress: will add more tests. cc rust-lang#100758
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved attribute collapse_debuginfo with variants:
#[collapse_debuginfo=(no|external|yes)]
.Added command-line flag for default behaviour.
Work-in-progress: will add more tests.
cc #100758