-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate section #119844
Remove duplicate section #119844
Conversation
For some reason the section was duplicated. There was a very minor variation in phrasing; I believe that no information is lost with this PR.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
r? @Amanieu |
This isn't exactly duplicated: there is technically a difference between "tier 1" and "tier 1 with host tools", it's just that at the moment these both contain the same set of targets. Perhaps it would be better to remove this distinction and only refer to these as "tier 1" targets. We could re-introduce the distinction if we ever add a tier 1 target without host tools. |
Thank you for the explanation, I think I now have a better understanding of this page. I could understand it would be easier to keep both sections than to create a new one later. At least to let readers know that they may eventually exists tier 1 without host tools. If the distinction exists in Rust community, my goal was really not to change the way concept are referenced. May I suggest, as you did with tier 2, titling the section explicitly "Tier 1 target without host tools". Should I open a bug report? I doubt this PR can be merged as-is, and I suspect this discussion may be better in a bug than a PR. Also, if the change is less trivial, it may be done in a different PR than this one |
I like the idea of making with/without host tools a sub-section of the tier. If you update your PR to do this then we can move forward with it. |
I hope this change will fit your requirement |
☔ The latest upstream changes (presumably #120196) made this pull request unmergeable. Please resolve the merge conflicts. |
Looks good! r=me once conflicts are resolved. |
ping @Arthur-Milchior can you resolve conflicts and rebase? |
@Arthur-Milchior any updates on this? thanks |
Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this. @rustbot label: +S-inactive |
For some reason the section was duplicated. There was a very minor variation in phrasing; I believe that no information is lost with this PR.