Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert effects description to doc comment #119866

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

smoelius
Copy link
Contributor

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 11, 2024
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 11, 2024

📌 Commit 7aec5de has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 12, 2024
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#119781 (fix typo)
 - rust-lang#119865 (Set `c_str_literals` stabilization version back to `CURRENT_RUSTC_VERSION`)
 - rust-lang#119866 (Convert `effects` description to doc comment)
 - rust-lang#119868 (Register even erroneous impls)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d61ac86 into rust-lang:master Jan 12, 2024
11 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Jan 12, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 12, 2024
Rollup merge of rust-lang#119866 - smoelius:patch-2, r=compiler-errors

Convert `effects` description to doc comment

So that it is visible here: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_feature/unstable/struct.Features.html#structfield.effects

r? `@fee1-dead`
@smoelius smoelius deleted the patch-2 branch January 12, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants