redesign stage 0 std #119899

onur-ozkan · 2024-01-12T17:57:42Z

This is intended to update bootstrap to use the beta standard library on stage 0, rather than compiling it from source (see the motivation at rust-lang/compiler-team#619).

The only drawback encountered was the requirement of using the stage 1 compiler to build the standard library from source. This issue has been resolved by adding the --build-std-on-stage0 flag. Therefore if the goal is to only build/test the compiled standard library without spending time on compiling rustc, it can be achieved by running x build --stage 0 std --build-std-on-stage0.

~~Blocked on #122709~~

rustbot · 2024-01-14T13:57:46Z

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

onur-ozkan · 2024-01-14T13:58:14Z

@rustbot ready

r? bootstrap
cc @rust-lang/libs

onur-ozkan · 2024-01-14T16:22:20Z

@rustbot author (currently stage 2 std is copied from stage 1 and this behaviour should change with the beta std change)

fbstj · 2024-08-05T15:27:57Z

library/std/src/sys/thread_local/static_local.rs

-        // FIXME: Use `SyncUnsafeCell` instead of allowing `static_mut_refs` lint
-        #[cfg_attr(bootstrap, allow(static_mut_ref))]
-        #[cfg_attr(not(bootstrap), allow(static_mut_refs))]
+        // FIXME: Use `SyncUnsafeCell` instead of allowing `static_mut_ref` lint


typo nit:

Suggested change

// FIXME: Use `SyncUnsafeCell` instead of allowing `static_mut_ref` lint

// FIXME: Use `SyncUnsafeCell` instead of allowing `static_mut_refs` lint

…default, r=Mark-Simulacrum use precompiled rustc for non-dist builders Makes non-dist builders to use precompiled CI rustc by default if they are available for the target triple. As we are going to make `rust.download-rustc=if-unchanged` default option with rust-lang#119899, we need to make sure `if-unchanged` logic never breaks and works as expected. As an addition, this will significantly improve the build times on CI when there's no change on the compiler. blocker for rust-lang#119899

…default, r=<try> use precompiled rustc for non-dist builders Makes non-dist builders to use precompiled CI rustc by default if they are available for the target triple. As we are going to make `rust.download-rustc=if-unchanged` default option with rust-lang#119899, we need to make sure `if-unchanged` logic never breaks and works as expected. As an addition, this will significantly improve the build times on CI when there's no change on the compiler. blocker for rust-lang#119899 try-job: aarch64-apple

…default, r=Mark-Simulacrum use precompiled rustc for non-dist builders Makes non-dist builders to use precompiled CI rustc by default if they are available for the target triple. As we are going to make `rust.download-rustc=if-unchanged` default option with rust-lang#119899, we need to make sure `if-unchanged` logic never breaks and works as expected. As an addition, this will significantly improve the build times on CI when there's no change on the compiler. blocker for rust-lang#119899 try-job: aarch64-apple

…default, r=<try> use precompiled rustc for non-dist builders Makes non-dist builders to use precompiled CI rustc by default if they are available for the target triple. As we are going to make `rust.download-rustc=if-unchanged` default option with rust-lang#119899, we need to make sure `if-unchanged` logic never breaks and works as expected. As an addition, this will significantly improve the build times on CI when there's no change on the compiler. blocker for rust-lang#119899 try-job: test-various

…default, r=Mark-Simulacrum use precompiled rustc for non-dist builders Makes non-dist builders to use precompiled CI rustc by default if they are available for the target triple. As we are going to make `rust.download-rustc=if-unchanged` default option with rust-lang#119899, we need to make sure `if-unchanged` logic never breaks and works as expected. As an addition, this will significantly improve the build times on CI when there's no change on the compiler. blocker for rust-lang#119899 try-job: test-various

…default, r=<try> use precompiled rustc for non-dist builders Makes non-dist builders to use precompiled CI rustc by default if they are available for the target triple. As we are going to make `rust.download-rustc=if-unchanged` default option with rust-lang#119899, we need to make sure `if-unchanged` logic never breaks and works as expected. As an addition, this will significantly improve the build times on CI when there's no change on the compiler. blocker for rust-lang#119899 try-job: x86_64-gnu-nopt

…default, r=<try> use precompiled rustc for non-dist builders Makes non-dist builders to use precompiled CI rustc by default if they are available for the target triple. As we are going to make `rust.download-rustc=if-unchanged` default option with rust-lang#119899, we need to make sure `if-unchanged` logic never breaks and works as expected. As an addition, this will significantly improve the build times on CI when there's no change on the compiler. blocker for rust-lang#119899 try-job: x86_64-gnu-nopt try-job: aarch64-apple

…default, r=Mark-Simulacrum use precompiled rustc for non-dist builders Makes non-dist builders to use precompiled CI rustc by default if they are available for the target triple. As we are going to make `rust.download-rustc=if-unchanged` default option with rust-lang#119899, we need to make sure `if-unchanged` logic never breaks and works as expected. As an addition, this will significantly improve the build times on CI when there's no change on the compiler. blocker for rust-lang#119899 try-job: x86_64-gnu-nopt try-job: aarch64-apple

Dylan-DPC · 2024-10-09T14:12:45Z

@onur-ozkan this is no longer blocked so if you can resolve the conflicts and mark it as ready for review from both github and bors pov then we can move this forward

onur-ozkan · 2024-10-12T07:01:08Z

@onur-ozkan this is no longer blocked so if you can resolve the conflicts and mark it as ready for review from both github and bors pov then we can move this forward

Yeah I am aware, I will work on this soon.

RalfJung · 2024-10-13T14:38:59Z

If this literally juts changes the std we use for stage 0 rustc, I think this change is highly confusing. We currently have the following bootstrap chain:
[bootstrap compiler] std (stage 0) -> compiler (stage 0) -> std (stage 1) -> compiler (stage 1)
Where every build uses the most recent compiler/library node in the chain for its own build.

Since this is a cycle, the "obvious alternative" is
[bootstrap compiler, bootstrap library] compiler (stage 0) -> std (stage 0) -> compiler (stage 1) -> std (stage 1)

Is that what this PR does? I.e., the stage 1 compiler now uses the stage 0 std? I think it should be, as that brings us back to a coherent bootstrap loop. If it just swaps the first two stages of our current loop, I am convinced this will cause no end of confusion and trouble since it will need special casing everywhere.

joboet · 2024-10-13T15:23:10Z

Is that what this PR does? I.e., the stage 1 compiler now uses the stage 0 std?

Yeah, that's the gist. Also take a look at the MCP, which has a nice diagram and also includes a proposal for using a different terminology than "stage 0".

RalfJung · 2024-10-13T15:33:24Z

Awesome. :-)

…r=Mark-Simulacrum use precompiled rustc for non-dist builders Makes non-dist builders to use precompiled CI rustc by default if they are available for the target triple. As we are going to make `rust.download-rustc=if-unchanged` default option with rust-lang/rust#119899, we need to make sure `if-unchanged` logic never breaks and works as expected. As an addition, this will significantly improve the build times on CI when there's no change on the compiler. blocker for #119899 try-job: x86_64-gnu-nopt try-job: aarch64-apple

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 12, 2024

onur-ozkan added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2024

This comment has been minimized.

Sign in to view

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jan 13, 2024

onur-ozkan force-pushed the redesign-stage0-std branch from 9fcee5c to 066ce06 Compare January 13, 2024 11:04

This comment has been minimized.

Sign in to view

onur-ozkan force-pushed the redesign-stage0-std branch from 066ce06 to 472c50c Compare January 13, 2024 13:09

This comment has been minimized.

Sign in to view

onur-ozkan force-pushed the redesign-stage0-std branch 2 times, most recently from ce81474 to b688ffa Compare January 13, 2024 15:51

This comment has been minimized.

Sign in to view

onur-ozkan force-pushed the redesign-stage0-std branch 6 times, most recently from 5f1747d to 00e59f0 Compare January 14, 2024 13:30

onur-ozkan marked this pull request as ready for review January 14, 2024 13:57

onur-ozkan changed the title ~~[WIP] redesign stage 0 std~~ redesign stage 0 std Jan 14, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 14, 2024

rustbot assigned albertlarsan68 Jan 14, 2024

onur-ozkan force-pushed the redesign-stage0-std branch from 00e59f0 to 8ac271c Compare January 14, 2024 14:41

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 14, 2024

fbstj reviewed Aug 5, 2024

View reviewed changes

onur-ozkan mentioned this pull request Oct 13, 2024

Bump to 1.84 #131560

Merged

onur-ozkan mentioned this pull request Oct 15, 2024

Tracking Issue for download-rustc improvements #131744

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

redesign stage 0 std #119899

redesign stage 0 std #119899

onur-ozkan commented Jan 12, 2024 •

edited by Dylan-DPC

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Jan 14, 2024

onur-ozkan commented Jan 14, 2024

onur-ozkan commented Jan 14, 2024

fbstj Aug 5, 2024

Dylan-DPC commented Oct 9, 2024

onur-ozkan commented Oct 12, 2024

RalfJung commented Oct 13, 2024 •

edited

Loading

joboet commented Oct 13, 2024

RalfJung commented Oct 13, 2024

	// FIXME: Use `SyncUnsafeCell` instead of allowing `static_mut_ref` lint
	// FIXME: Use `SyncUnsafeCell` instead of allowing `static_mut_refs` lint

redesign stage 0 std #119899

Are you sure you want to change the base?

redesign stage 0 std #119899

Conversation

onur-ozkan commented Jan 12, 2024 • edited by Dylan-DPC Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Jan 14, 2024

onur-ozkan commented Jan 14, 2024

onur-ozkan commented Jan 14, 2024

fbstj Aug 5, 2024

Choose a reason for hiding this comment

Dylan-DPC commented Oct 9, 2024

onur-ozkan commented Oct 12, 2024

RalfJung commented Oct 13, 2024 • edited Loading

joboet commented Oct 13, 2024

RalfJung commented Oct 13, 2024

onur-ozkan commented Jan 12, 2024 •

edited by Dylan-DPC

Loading

RalfJung commented Oct 13, 2024 •

edited

Loading