Split out option::unwrap_failed like we have result::unwrap_failed

[scottmcm]

...and like option::expect_failed

[rustbot]

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

[scottmcm]

@bors try @rust-timer queue

[bors]

⌛ Trying commit f4da345 with merge 692ec2a...

[bors]

☀️ Try build successful - checks-actions
Build commit: 692ec2a (692ec2a053f44992c252155a7910f1a1bce54ff3)

[rust-timer]

Finished benchmarking commit (692ec2a): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.6%	[1.6%, 1.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.4%, -0.3%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.6%	[2.6%, 2.6%]	1
Regressions ❌ (secondary)	2.0%	[1.0%, 2.4%]	5
Improvements ✅ (primary)	-4.3%	[-4.3%, -4.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.9%	[-4.3%, 2.6%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.6%	[2.6%, 2.6%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.6%	[2.6%, 2.6%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 664.704s -> 666.689s (0.30%)
Artifact size: 308.20 MiB -> 308.12 MiB (-0.03%)

[scottmcm]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 2348366 with merge c61a739...

[bors]

☀️ Try build successful - checks-actions
Build commit: c61a739 (c61a73945463864704bd6b76010d6eb4ca5f98e4)

[rust-timer]

Finished benchmarking commit (c61a739): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.0%	[3.0%, 3.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-5.2%	[-6.3%, -4.1%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.2%	[-6.3%, 3.0%]	4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[1.3%, 2.5%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 666.665s -> 668.577s (0.29%)
Artifact size: 308.23 MiB -> 308.12 MiB (-0.03%)

[scottmcm]

Since you asked about this in the other PR,
r? @WaffleLapkin

[WaffleLapkin]

@bors r+

[bors]

📌 Commit 2348366 has been approved by WaffleLapkin

It is now in the queue for this repository.

[scottmcm]

@bors ping

[bors]

😪 I'm awake I'm awake

[scottmcm]

Trying to poke bors since this isn't showing in the queue
@bors r-

[scottmcm]

@bors r=WaffleLapkin

[bors]

📌 Commit 2348366 has been approved by WaffleLapkin

It is now in the queue for this repository.

[bors]

⌛ Testing commit 2348366 with merge bf2637f...

[bors]

☀️ Test successful - checks-actions
Approved by: WaffleLapkin
Pushing bf2637f to master...

[rust-timer]

Finished benchmarking commit (bf2637f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	7.7%	[5.2%, 12.0%]	5
Regressions ❌ (secondary)	1.3%	[1.3%, 1.3%]	1
Improvements ✅ (primary)	-5.2%	[-5.2%, -5.2%]	1
Improvements ✅ (secondary)	-3.7%	[-4.0%, -3.5%]	2
All ❌✅ (primary)	5.5%	[-5.2%, 12.0%]	6

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 664.25s -> 666.444s (0.33%)
Artifact size: 308.27 MiB -> 308.25 MiB (-0.00%)