Move getopts out of extra #12007
Move getopts out of extra #12007
Conversation
|
cc @cmr |
|
Awesome! Needs a rebase, Also, please remove getopts and make getopts::groups the only option. |
|
Do you mean replace the base getopts and its functions (e.g. optopt) with the ones in getopts::groups? |
|
yes On Mon, Feb 3, 2014 at 12:42 AM, Arcterus notifications@github.com wrote:
|
|
Alright, working on that. :) |
|
@cmr: I believe that I've implemented your request. |
|
From my brief glance (not a full review), looks good! However, it looks like there's a few duplicated tests now, and you can probably delete a bunch of them. :) |
|
They seem to be mostly the same, but some check for the long form while others check for the short form. Would it be better to keep them separated or would you rather me merge them? |
|
Merging would be good, otherwise the module will be "infected" by its history (e.g. tests called |
|
True. I'll try to do that soon. |
|
The tests have been merged. |
|
I think this needs to be rebased |
|
This is ready to be merged again. |
Should help towards finishing #8784.
…, r=jonas-schievink Restart proc-macro client when server reload Fix rust-lang#10719
…s-with-brackets, r=Jarcho New Lint: empty_enum_variants_with_brackets This PR: - adds a new early pass lint that checks for enum variants with no fields that were defined using brackets. **Category: Restriction** - adds relevant UI tests for the new lint. Closes rust-lang#12007 ``` changelog: New lint: [`empty_enum_variants_with_brackets`] ```
Should help towards finishing #8784.