Subtree update of `rust-analyzer` #120198

lnicola · 2024-01-21T14:54:20Z

Add a stable #visual-studio anchor to the Manual Helpful for rust-lang/www.rust-lang.org#1915 so we have a persistent place to link as "Visual Studio" from the Rust website. Syntax reference: https://docs.asciidoctor.org/asciidoc/latest/sections/custom-ids/#assign-auxiliary-ids

…rgo metadata`

…m-ra

Follow the rename in nightly (see https://blog.rust-lang.org/inside-rust/2023/10/23/coroutines.html)

internal: sync from downstream

…e, r=Veykril Rename generator to coroutine Follow the rename in nightly (see https://blog.rust-lang.org/inside-rust/2023/10/23/coroutines.html) This makes it much easier to test code with the nightly compiler.

internal: Eagerly lower enum variants in CrateDefMap construction

Work through temporarily allowed clippy lints, part 1 This is the first batch of not allowing but actually fixing the clippy lints. Each commit removes one lint from the lint table and then fixes the resulting warnings. Follow-up to rust-lang#16401

fix panic with reference in macro it panic at `builder.make_mut(segment)`, where segment is from macro expand. And the usage reference in orginal macro call isn't a `PathSegment` so we can't update it in `apply_references`, I can't find a way to deal with it properly so here just filter out the reference in macro. LMK if there are better way to fix this try to close rust-lang/rust-analyzer#16328

…lnicola fix: Include `for` construct in convert to guarded return conditions

internal: add `max_line_length` to `.editorconfig` This helps with setting proper visual guides/rulers for the right margin in some editors/IDEs (e.g. CLion)

…m-ra

rustbot · 2024-01-21T14:54:25Z

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

lnicola · 2024-01-21T14:57:13Z

@bors r+ p=1 subtree update

bors · 2024-01-21T14:57:16Z

📌 Commit 595b4c3 has been approved by lnicola

It is now in the queue for this repository.

bors · 2024-01-21T16:14:55Z

⌛ Testing commit 595b4c3 with merge ef71f10...

bors · 2024-01-21T18:14:39Z

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing ef71f10 to master...

rust-timer · 2024-01-21T20:05:48Z

Finished benchmarking commit (ef71f10): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.3%	[1.3%, 1.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.5%	[-0.5%, -0.5%]	2

Bootstrap: 662.236s -> 663.041s (0.12%)
Artifact size: 308.38 MiB -> 308.37 MiB (-0.01%)

9999years and others added 30 commits January 9, 2024 09:16

Show which roots are being scanned in progress messages

1ceb2ea

See: rust-lang#12613

fix: add err recovery for use_tree_list parsing

e6dd522

fix broken test

afe05fe

add in-comment test case for use_tree_list_err_recovery

45eea57

order use trees following rustfmt's algorithm for ordering imports

4a6b16b

fix: failed to infer OUT_DIR when workspace root contains symlink

22cda95

internal: Speedup line index calculation via NEON for aarch64

7c3744e

fix: add USE_TREE_LIST_FIRST_SET

d0b310f

test: correct expected test result

6033b66

internal: add inline for move_mask in line-index

df53828

order merged use trees

22ae5f4

improve use tree simple path comparison logic

db3f0f1

improve ordered use tree merging implementation

d4b43d5

Add a stable #visual-studio anchor to the Manual

02d21f2

internal: Add unstable config for loading the sysroot sources via `ca…

c7eb52d

…rgo metadata`

Eagerly lower enum variants in CrateDefMap construction

d80d2fc

Merge commit '9d8889cdfcc3aa0302353fc988ed21ff9bc9925c' into sync-fro…

6bbd106

…m-ra

Deduplicate

2d72ec7

Thinner DefDiagnostics

1669344

Cleanup

180e9b2

internal: re-generate lints.rs

a356172

fix: rename generator to coroutine

f937673

Follow the rename in nightly (see https://blog.rust-lang.org/inside-rust/2023/10/23/coroutines.html)

fix: rename generator to coroutine also in dependencies

fe35447

Follow the rename in nightly (see https://blog.rust-lang.org/inside-rust/2023/10/23/coroutines.html)

Merge branch 'master' into sync-from-rust

ff71513

Merge remote-tracking branch 'upstream/master' into sync-from-rust

a2aee95

Auto merge of rust-lang#16364 - lnicola:sync-from-rust, r=lnicola

b9fd12b

internal: sync from downstream

Auto merge of rust-lang#16196 - mohe2015:rename-generator-to-coroutin…

4de8954

…e, r=Veykril Rename generator to coroutine Follow the rename in nightly (see https://blog.rust-lang.org/inside-rust/2023/10/23/coroutines.html) This makes it much easier to test code with the nightly compiler.

Auto merge of rust-lang#16351 - Veykril:eager-enum-variant, r=Veykril

5df53c9

internal: Eagerly lower enum variants in CrateDefMap construction

Urhengulas and others added 17 commits January 19, 2024 17:31

redundant_locals

9527e24

ptr_arg

6738edc

question_mark

3cf1358

redundant_closure

5a62a0d

redundant_pattern_matching

71d4dba

search_is_some

159b4c9

should_implement_trait

9dd07f0

single_match

b1a0c9a

redundant_locals

9e83779

minor: use reference.range to get original range

f9b5e0d

include for in convert to guarded return assist

721e790

add max_line_length to .editorconfig

5aa7583

Auto merge of rust-lang#16405 - dfireBird:guarded-return-for-loop, r=…

d4926c1

…lnicola fix: Include `for` construct in convert to guarded return conditions

Auto merge of rust-lang#16406 - davidsemakula:editorconfig, r=lnicola

a911652

internal: add `max_line_length` to `.editorconfig` This helps with setting proper visual guides/rulers for the right margin in some editors/IDEs (e.g. CLion)

Merge commit 'a9116523604c998e7781f60d3b5a6f586e0414a9' into sync-fro…

595b4c3

…m-ra

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 21, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 21, 2024

bors merged commit ef71f10 into rust-lang:master Jan 21, 2024

rustbot added this to the 1.77.0 milestone Jan 21, 2024

lnicola deleted the sync-from-ra branch January 21, 2024 18:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Subtree update of `rust-analyzer` #120198

Subtree update of `rust-analyzer` #120198

Uh oh!

lnicola commented Jan 21, 2024

Uh oh!

rustbot commented Jan 21, 2024

Uh oh!

lnicola commented Jan 21, 2024

Uh oh!

bors commented Jan 21, 2024

Uh oh!

bors commented Jan 21, 2024

Uh oh!

bors commented Jan 21, 2024

Uh oh!

rust-timer commented Jan 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

Subtree update of rust-analyzer #120198

Subtree update of rust-analyzer #120198

Uh oh!

Conversation

lnicola commented Jan 21, 2024

Uh oh!

rustbot commented Jan 21, 2024

Uh oh!

lnicola commented Jan 21, 2024

Uh oh!

bors commented Jan 21, 2024

Uh oh!

bors commented Jan 21, 2024

Uh oh!

bors commented Jan 21, 2024

Uh oh!

rust-timer commented Jan 21, 2024

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

Subtree update of `rust-analyzer` #120198

Subtree update of `rust-analyzer` #120198