Removed @self and @Trait. #12030
Merged
Removed @self and @Trait. #12030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -136,10 +137,10 @@ pub fn build_configuration(sess: Session) -> | |||
| } | |||
|
|
|||
| // Convert strings provided as --cfg [cfgspec] into a crate_cfg | |||
| fn parse_cfgspecs(cfgspecs: ~[~str], demitter: @diagnostic::Emitter) | |||
There was a problem hiding this comment.
How come the emitter was removed from all of these functions?
You could imagine a compiler invocation to want a different emitter, but if it was too painful to pass around then removing @ is probably more pressing.
There was a problem hiding this comment.
There is no other implementation of Emitter at this moment, seems a bit ridiculous to go through a trait object.
I've left most of the framework in place, in case we need something generic later (and then we can implement it sanely).
|
Heroic effort, nice work! |
|
nice |
|
As a side-effect, some trait operations produce cleaner IR (now that fn foo(x: ~Clone) {
let y: &Clone = x;
}; before
define internal void @foo({ void (i8*)**, i8* }*) unnamed_addr #4 {
entry-block:
%x = alloca { void (i8*)**, i8* }
%y = alloca { void (i8*)**, i8* }
%__auto_borrow_obj = alloca { void (i8*)**, i8* }
%1 = bitcast { void (i8*)**, i8* }* %0 to i8*
%2 = bitcast { void (i8*)**, i8* }* %x to i8*
call void @llvm.memcpy.p0i8.p0i8.i64(i8* %2, i8* %1, i64 16, i32 8, i1 false)
%3 = getelementptr inbounds { void (i8*)**, i8* }* %x, i32 0, i32 0
%4 = load void (i8*)*** %3
%5 = getelementptr inbounds { void (i8*)**, i8* }* %__auto_borrow_obj, i32 0, i32 0
store void (i8*)** %4, void (i8*)*** %5
%6 = getelementptr inbounds { void (i8*)**, i8* }* %x, i32 0, i32 1
%7 = load i8** %6
%8 = getelementptr inbounds { void (i8*)**, i8* }* %__auto_borrow_obj, i32 0, i32 1
store i8* %7, i8** %8
%9 = bitcast { void (i8*)**, i8* }* %__auto_borrow_obj to i8*
%10 = bitcast { void (i8*)**, i8* }* %y to i8*
call void @llvm.memcpy.p0i8.p0i8.i64(i8* %10, i8* %9, i64 16, i32 8, i1 false)
call void @"~std::clone::Clone.Send::glue_drop"({ void (i8*)**, i8* }* %x)
ret void
}; after
define internal void @foo({ void (i8*)**, i8* }*) unnamed_addr #4 {
entry-block:
%y = alloca { void (i8*)**, i8* }
%1 = bitcast { void (i8*)**, i8* }* %0 to i8*
%2 = bitcast { void (i8*)**, i8* }* %y to i8*
call void @llvm.memcpy.p0i8.p0i8.i64(i8* %2, i8* %1, i64 16, i32 8, i1 false)
call void @"~std::clone::Clone.Send::glue_drop"({ void (i8*)**, i8* }* %0)
ret void
} |
bors
added a commit
that referenced
this pull request
Feb 6, 2014
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 11, 2024
…uote-in-char-literal, r=llogiq 11973: Don't escape `"` in `'"'` Fixes rust-lang#11973. ``` changelog: [`single_char_pattern`]: don't escape `"` in `'"'` ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.