Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove various has_errors or err_count uses #120342

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Remove various has_errors or err_count uses #120342

merged 6 commits into from
Jan 30, 2024

Commits on Jan 25, 2024

  1. Stop checking err_count in macro_rules validity checking 

    All errors are local anyway, so we can track them directly
    @oli-obk
    oli-obk committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    f68741b View commit details
    Browse the repository at this point in the history

  2. Remove an unused error count check

    @oli-obk
    oli-obk committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    f6f0e04 View commit details
    Browse the repository at this point in the history

  3. Statically ensure an error is reported in report_arg_errors

    @oli-obk
    oli-obk committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    646c8fc View commit details
    Browse the repository at this point in the history

  4. Statically ensure report_selection_error actually reports an error

    @oli-obk
    oli-obk committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    2b60e56 View commit details
    Browse the repository at this point in the history

  5. Remove has_errors check in builtin macro parsing

    @oli-obk
    oli-obk committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    3042da0 View commit details
    Browse the repository at this point in the history

  6. Track ErrorGuaranteed instead of conjuring it from thin air

    @oli-obk
    oli-obk committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    054e1e3 View commit details
    Browse the repository at this point in the history