Implement RFC 3373: Avoid non-local definitions in functions #120393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
This comment has been minimized.
This comment has been minimized.
bjorn3
reviewed
Jan 26, 2024
Noratrieb
reviewed
Jan 26, 2024
Urgau
force-pushed
the
rfc3373-non-local-defs
branch
from
a558e54
to
c6f8d02
Compare
This comment has been minimized.
This comment has been minimized.
|
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt |
ytmimi
reviewed
Jan 26, 2024
This comment has been minimized.
This comment has been minimized.
Urgau
force-pushed
the
rfc3373-non-local-defs
branch
from
844e9bd
to
e9aeaaa
Compare
This comment has been minimized.
This comment has been minimized.
Nadrieril
added a commit
to Nadrieril/rust
that referenced
this pull request
Jan 27, 2024
…piler-errors Improve handling of numbers in `IntoDiagnosticArg` While working on rust-lang#120393, I realize that my fluent selectors were not working. So here is an improvement (not a fix unfortunately).
Nadrieril
added a commit
to Nadrieril/rust
that referenced
this pull request
Jan 27, 2024
…piler-errors Improve handling of numbers in `IntoDiagnosticArg` While working on rust-lang#120393, I realize that my fluent selectors were not working. So here is an improvement (not a fix unfortunately).
Nadrieril
added a commit
to Nadrieril/rust
that referenced
this pull request
Jan 27, 2024
…piler-errors Improve handling of numbers in `IntoDiagnosticArg` While working on rust-lang#120393, I realize that my fluent selectors were not working. So here is an improvement (not a fix unfortunately).
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 27, 2024
…piler-errors Improve handling of numbers in `IntoDiagnosticArg` While working on rust-lang#120393, I realize that my fluent selectors were not working. So here is an improvement (not a fix unfortunately).
Urgau
force-pushed
the
rfc3373-non-local-defs
branch
from
e9aeaaa
to
686077e
Compare
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 27, 2024
Rollup merge of rust-lang#120398 - Urgau:into_diag_arg-numbers, r=compiler-errors Improve handling of numbers in `IntoDiagnosticArg` While working on rust-lang#120393, I realize that my fluent selectors were not working. So here is an improvement (not a fix unfortunately).
This comment has been minimized.
This comment has been minimized.
Urgau
force-pushed
the
rfc3373-non-local-defs
branch
from
686077e
to
db51d11
Compare
This comment has been minimized.
This comment has been minimized.
Urgau
force-pushed
the
rfc3373-non-local-defs
branch
from
db51d11
to
27d6eaa
Compare
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 26, 2024
…=<try> Recover most of the perf loss of rust-lang#120393 [rust-lang#120393](rust-lang#120393 (comment)) draft for perf
5 tasks
7 tasks
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 26, 2024
…=<try> Recover most of the perf loss of rust-lang#120393 [rust-lang#120393](rust-lang#120393 (comment)) draft for perf
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 27, 2024
…=<try> Recover most of the perf loss of rust-lang#120393 [rust-lang#120393](rust-lang#120393 (comment)) draft for perf
|
For perf triage I'm going to mark this as triaged since #121625 is meant to try to address this. However, I hope that PR is currently only recovering a small fraction of the performance loss here. Given the complex nature of the change, I imagine a revert is not desirable though even if performance can't be gained back. @rustbot label: +perf-regression-triaged |
rustbot
added
the
perf-regression-triaged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 27, 2024
…=<try> Recover most of the perf loss of rust-lang#120393 [rust-lang#120393](rust-lang#120393 (comment)) draft for perf
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 27, 2024
…=<try> Recover most of the perf loss of rust-lang#120393 [rust-lang#120393](rust-lang#120393 (comment)) draft for perf
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 28, 2024
…=<try> Recover most of the perf loss of rust-lang#120393 [rust-lang#120393](rust-lang#120393 (comment)) draft for perf
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 29, 2024
…=<try> Recover most of the perf loss of rust-lang#120393 [rust-lang#120393](rust-lang#120393 (comment)) draft for perf
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 29, 2024
…=<try> Recover most of the perf loss of rust-lang#120393 [rust-lang#120393](rust-lang#120393 (comment)) draft for perf
|
@rylev I tried very hard in #121625 to fix the perf regression, but it when mostly nowhere. My latest (and most promising) attempt end up having a correctness issue. At some point I was wondering why diesel was the only benchmark to show any regressions (even in incremental), just to realize that in the Crater run some older versions of the crate were affect by the lint; and indeed it now produces 155 warnings! No wonder why my all attempts went no-where. If only I could have gotten kcachegrind working earlier it would have screamed this to me; it shows that 99.39% the instructions in the lint is the diagnostic machinery. So in summary, there is no perf-regression per se, For those curious: |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 7, 2024
…leLapkin Implement RFC 3373: Avoid non-local definitions in functions This PR implements [RFC 3373: Avoid non-local definitions in functions](rust-lang#120363).
Merged
This was referenced May 28, 2024
7 tasks
calebcartwright
pushed a commit
to calebcartwright/rust
that referenced
this pull request
Jun 22, 2024
…leLapkin Implement RFC 3373: Avoid non-local definitions in functions This PR implements [RFC 3373: Avoid non-local definitions in functions](rust-lang#120363).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements RFC 3373: Avoid non-local definitions in functions.