export std::comm::select! macro #12043
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sadly this isn't quite ready yet. I need to redesign it slightly and re-implement portions of it to actually be reliable. I'm closing this for now because I don't think it's quite ready yet. My first order of business is to land #11578 first, and as part of that I'll need to get select working again for the rewritten channels. I'll try to export select soon after that though! |
|
I've opened #12044 on the issue. |
|
Ah gotcha. Looking forward to the day #11578 lands! |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
…-schievink fix: index the correct CargoWorkspace with rustc_private I believe this fixes rust-lang#12043, but I'm not sufficiently setup/familiar with working on rust-analyzer to test it locally. :/ This section of code is iterating on `rustc_workspace.packages()` but then indexes `cargo[pkg]`, which is likely the source of the bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exports the select! macro so it can actually be used