Only emit gep not gepi

[saethlin]

r? @ghost

A handful of people were speculating about the perf impact of gep vs gepi so let's see what this does....

[saethlin]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 2ca30e9 with merge c795a6f...

[bors]

☀️ Try build successful - checks-actions
Build commit: c795a6f (c795a6f6a3cdae4dce4c3b8bf59b30386babfec7)

[rust-timer]

Finished benchmarking commit (c795a6f): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.7%	[0.7%, 6.5%]	236
Regressions ❌ (secondary)	2.8%	[0.5%, 9.0%]	227
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.7%	[0.7%, 6.5%]	236

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.3%	[-4.3%, -4.3%]	1
Improvements ✅ (secondary)	-1.0%	[-1.0%, -1.0%]	1
All ❌✅ (primary)	-1.1%	[-4.3%, 2.1%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.7%	[0.7%, 4.0%]	70
Regressions ❌ (secondary)	6.1%	[1.1%, 17.8%]	22
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.7%	[0.7%, 4.0%]	70

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.1%, 1.0%]	25
Regressions ❌ (secondary)	1.0%	[0.3%, 1.3%]	39
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.1%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[-0.1%, 1.0%]	28

Bootstrap: 661.382s -> 675.337s (2.11%)
Artifact size: 308.09 MiB -> 308.13 MiB (0.01%)

[Kobzol]

Interesting, looks like some nice wins on runtime hashmap benchmarks 🤔

[saethlin]

Yeah. I'll look into that later, but for now I have my answer.