Make NonZero::get generic.

[reitermarkus]

Tracking issue: #120257

Depends on #120521.

r? @dtolnay

[dtolnay]

I reviewed the 3rd commit only (the first 2 are identical to #120521 based on commit hash).

Looks good!

#119452 added codegen tests (@AngelicosPhosphoros thank you 👏 👏) so as long as those are good, I am happy with this PR.

[dtolnay]

@bors delegate+

Please rebase after #120521 lands, so we see just get changes in https://github.com/rust-lang/rust/pull/120563/files, and then approve this yourself. Thanks!

After #120521 is merged and then #120486 is rebased and merged, regardless of whether this PR has been merged by that point, I plan to propose stabilization on #120257. Between the time for the team to approve the stabilization, and land a stabilization PR, and then the nightly and beta period, it will give enough time in my opinion to bail out if anything appears to be going wrong with generic nonzero.

[bors]

✌️ @reitermarkus, you can now approve this pull request!

If @dtolnay told you to "r=me" after making some further change, please make that change, then do @bors r=@dtolnay

[reitermarkus]

#119452 added codegen tests

Yes, I specifically ran these tests locally, so hopefully should be fine.

[bors]

☔ The latest upstream changes (presumably #120521) made this pull request unmergeable. Please resolve the merge conflicts.

[reitermarkus]

@bors r=dtolnay

[bors]

📌 Commit 24e2cf0 has been approved by dtolnay

It is now in the queue for this repository.

[bors]

⌛ Testing commit 24e2cf0 with merge 439d69c...

[bors]

💔 Test failed - checks-actions

[rust-log-analyzer]

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling mdbook v0.4.37
[RUSTC-TIMING] elasticlunr test:false 5.487
[RUSTC-TIMING] ammonia test:false 5.021
[RUSTC-TIMING] handlebars test:false 10.790
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
##[group]Clock drift check
  local time: Sat Feb 17 00:01:58 UTC 2024
  network time: Sat, 17 Feb 2024 00:01:58 GMT
##[endgroup]
##[endgroup]
Session terminated, killing shell... ...killed.
##[error]The operation was canceled.

[dtolnay]

Can't tell what failed.

@bors retry
@bors delegate+

[bors]

✌️ @reitermarkus, you can now approve this pull request!

If @dtolnay told you to "r=me" after making some further change, please make that change, then do @bors r=@dtolnay

[bors]

⌛ Testing commit 24e2cf0 with merge 4316d0c...

[bors]

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing 4316d0c to master...

[rust-timer]

Finished benchmarking commit (4316d0c): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.9%, 2.9%]	1
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.5%	[-0.5%, -0.5%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-5.1%	[-8.0%, -2.3%]	4
Improvements ✅ (secondary)	-4.5%	[-5.1%, -3.8%]	2
All ❌✅ (primary)	-5.1%	[-8.0%, -2.3%]	4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-8.6%	[-8.6%, -8.6%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.2%]	20
Regressions ❌ (secondary)	0.9%	[0.8%, 0.9%]	3
Improvements ✅ (primary)	-0.3%	[-2.4%, -0.1%]	14
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-2.4%, 0.2%]	34

Bootstrap: 638.214s -> 639.28s (0.17%)
Artifact size: 306.34 MiB -> 306.36 MiB (0.00%)