Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark UEFI std support as WIP #120640

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Mark UEFI std support as WIP #120640

merged 1 commit into from
Mar 17, 2024

Conversation

Ayush1325
Copy link
Contributor

@Ayush1325 Ayush1325 commented Feb 4, 2024

Currently stdio and alloc support is present with open PRs for some of the other portions.

A prototype of almost all of std support can be found here. I will be up-streaming as much stuff as possible from there.

@rustbot
Copy link
Collaborator

rustbot commented Feb 4, 2024

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 4, 2024
@bors
Copy link
Contributor

bors commented Mar 5, 2024

☔ The latest upstream changes (presumably #121998) made this pull request unmergeable. Please resolve the merge conflicts.

Signed-off-by: Ayush Singh <ayushdevel1325@gmail.com>
@Ayush1325
Copy link
Contributor Author

@@ -118,6 +118,7 @@ The `std` column in the table below has the following meanings:

* ✓ indicates the full standard library is available.
* \* indicates the target only supports [`no_std`] development.
* ? indicates the standard library support is unknown or a work-in-progress.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, the wording here was suggested on zulip: https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/Std.20status.20for.20UEFI/near/419113012

Only question I have is whether there are really targets where the support is unknown? I would expect that since the targets are implemented in this repo we would know whether they support std or not, but I don't know for sure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing should ever be unknown except when it's badly documented (which a lot of this stuff here is!), so especially when starting to migrate #120745, a lot of things will probably be unknown and someone will have to figure it out.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense :)

@Noratrieb
Copy link
Member

thanks for pinging me, looks good. I'll also remember this when adding the new target documentation generator to make sure this "partial" or "WIP" is better displayed.
@bors r+

@bors
Copy link
Contributor

bors commented Mar 17, 2024

📌 Commit c1cf422 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 17, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#120640 (Mark UEFI std support as WIP)
 - rust-lang#121862 (Add release notes for 1.77.0)
 - rust-lang#122572 (add test for rust-lang#122301 to cover behavior that's on stable)
 - rust-lang#122578 (Only invoke `decorate` if the diag can eventually be emitted)
 - rust-lang#122615 (Mention Zalathar for coverage changes)
 - rust-lang#122636 (some minor code simplifications)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3d1b04e into rust-lang:master Mar 17, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Mar 17, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 17, 2024
Rollup merge of rust-lang#120640 - Ayush1325:uefi-doc, r=Nilstrieb

Mark UEFI std support as WIP

Currently stdio and alloc support is present with open PRs for some of the other portions.

A prototype of almost all of std support can be found [here](https://github.com/tianocore/rust/tree/uefi-master). I will be up-streaming as much stuff as possible from there.
@Ayush1325 Ayush1325 deleted the uefi-doc branch March 18, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants