Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

match lowering: eagerly simplify match pairs #120904

Merged
merged 8 commits into from
Feb 21, 2024
Merged

match lowering: eagerly simplify match pairs #120904

merged 8 commits into from
Feb 21, 2024

Commits on Feb 19, 2024

  1. Switch to Vec of MatchPairs 

    Because I'm about to make MatchPair recursive, which I can't do with
SmallVec, and I need to share code between the two.
    @Nadrieril
    Nadrieril committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    48b83e8 View commit details
    Browse the repository at this point in the history

  2. Move Or test outside of simplify_candidate

    @Nadrieril
    Nadrieril committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    bafad5a View commit details
    Browse the repository at this point in the history

  3. Make simplify_candidate more general 

    Because we will soon need to apply it to match pairs that aren't
directly in a candidate.
    @Nadrieril
    Nadrieril committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    e86c822 View commit details
    Browse the repository at this point in the history

  4. Don't repeatedly simplify already-simplified match pairs

    @Nadrieril
    Nadrieril committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    308b482 View commit details
    Browse the repository at this point in the history

  5. Eagerly simplify match pairs

    @Nadrieril
    Nadrieril committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    d936ab6 View commit details
    Browse the repository at this point in the history

  6. Compute subpairs when creating match pair

    @Nadrieril
    Nadrieril committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    1507276 View commit details
    Browse the repository at this point in the history

  7. Don't default fully_matched to false to avoid mistakes

    @Nadrieril
    Nadrieril committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    0ca1d22 View commit details
    Browse the repository at this point in the history

  8. Update comments

    @Nadrieril
    Nadrieril committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    328c776 View commit details
    Browse the repository at this point in the history