Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm-wrapper: adapt for LLVM API change: Add support for EXPORTAS name types #120974

Merged
merged 1 commit into from
Feb 13, 2024
Merged

llvm-wrapper: adapt for LLVM API change: Add support for EXPORTAS name types #120974

merged 1 commit into from
Feb 13, 2024

Conversation

zmodem
Copy link
Contributor

@zmodem zmodem commented Feb 12, 2024

@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2024

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 12, 2024
@zmodem
Copy link
Contributor Author

zmodem commented Feb 12, 2024

Can someone please apply the llvm-main label?

@TimNN

@nikic nikic added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Feb 12, 2024
@TimNN
Copy link
Contributor

TimNN commented Feb 12, 2024

Thanks Nikita for applying the label!

@zmodem: FYI: Things should be set up so that anyone can apply that label by commenting @rustbot label:+llvm-main, so in the future you can just include that in the initial comment.

@zmodem
Copy link
Contributor Author

zmodem commented Feb 12, 2024

@zmodem: FYI: Things should be set up so that anyone can apply that label by commenting @rustbot label:+llvm-main, so in the future you can just include that in the initial comment.

Thanks! I'll do that next time.

@klensy klensy mentioned this pull request Feb 12, 2024
Closed
@durin42
Copy link
Contributor

durin42 commented Feb 12, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 12, 2024

📌 Commit 718b304 has been approved by durin42

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 13, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 13, 2024
@bors
Auto merge of rust-lang#121003 - matthiaskrgr:rollup-u5wyztn, r=matth…
fd9bb7f 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#120696 (Properly handle `async` block and `async fn` in `if` exprs without `else`)
 - rust-lang#120751 (Provide more suggestions on invalid equality where bounds)
 - rust-lang#120802 (Bail out of drop elaboration when encountering error types)
 - rust-lang#120967 (docs: mention round-to-even in precision formatting)
 - rust-lang#120973 (allow static_mut_ref in some tests that specifically test mutable statics)
 - rust-lang#120974 (llvm-wrapper: adapt for LLVM API change: Add support for EXPORTAS name types)
 - rust-lang#120986 (iterator.rs: remove "Basic usage" text)
 - rust-lang#120987 (remove redundant logic)
 - rust-lang#120988 (fix comment)
 - rust-lang#120995 (PassWrapper: adapt for llvm/llvm-project@93cdd1b5cfa3735c)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fa3ec02 into rust-lang:master Feb 13, 2024
11 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Feb 13, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 13, 2024
@rust-timer
Unrolled build for rust-lang#120974
ec00382 
Rollup merge of rust-lang#120974 - zmodem:exportas, r=durin42

llvm-wrapper: adapt for LLVM API change: Add support for EXPORTAS name types

Adapt for llvm/llvm-project@8f23464.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.
7 participants
@zmodem @rustbot @TimNN @durin42 @bors @cuviper @nikic