Format async trait bounds in rustfmt
#121035
Conversation
rustbot
added
the
S-waiting-on-review
|
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt |
|
@compiler-errors thanks for putting a PR together so quickly. rust-lang/rustfmt#6070 mentioned that the issue was related to experimental syntax. Is this also impacting stable syntax? I don't see a feature attribute in the test case. |
|
@ytmimi: Does rustfmt even check feature gating? |
Is that something that rustfmt could check? I wouldn't expect that information to be available in the AST. |
|
@ytmimi: I'm just confused what you're asking for. I didn't include a |
|
@compiler-errors sorry, I was confused when I didn't see Even if it's unnecessary for rustfmt, I think it would be valuable to include the required features directly in the test case so that it's clearer that this is for a new feature. |
|
@bors r+ |
bors
added
S-waiting-on-bors
…llaumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#120893 (Move some tests) - rust-lang#120966 (Remove importing suggestions when there is a shadowed typo candidate) - rust-lang#121035 (Format `async` trait bounds in rustfmt) - rust-lang#121075 (Fix false positive with if let and ranges) - rust-lang#121083 (Extend documentation for `Ty::to_opt_closure_kind` method) - rust-lang#121084 (Make sure `tcx.create_def` also depends on the forever red node, instead of just `tcx.at(span).create_def`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#121035 - compiler-errors:rustfmt-asyncness, r=calebcartwright Format `async` trait bounds in rustfmt r? `@ytmimi` or `@calebcartwright` This PR opts to do formatting in the rust-lang/rust tree because otherwise we'd have to wait until a full sync, and rustfmt is currently totally removing the `async` keyword. cc rust-lang/rustfmt#6070
Rustup With rust-lang/rust#121035 landed we can rustfmt format `async FnOnce`.
Rustup With rust-lang/rust#121035 landed we can rustfmt format `async FnOnce`.
Rustup With rust-lang#121035 landed we can rustfmt format `async FnOnce`.
… r=calebcartwright Format `async` trait bounds in rustfmt r? `@ytmimi` or `@calebcartwright` This PR opts to do formatting in the rust-lang/rust tree because otherwise we'd have to wait until a full sync, and rustfmt is currently totally removing the `async` keyword. cc rust-lang/rustfmt#6070
r? @ytmimi or @calebcartwright
This PR opts to do formatting in the rust-lang/rust tree because otherwise we'd have to wait until a full sync, and rustfmt is currently totally removing the
asynckeyword.cc rust-lang/rustfmt#6070