Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rust.frame-pointers config option #121203

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Add rust.frame-pointers config option #121203

merged 1 commit into from
Feb 19, 2024

Conversation

Noratrieb
Copy link
Member

This is very helpful for profiling. I've hacked this in many times, so let's add it properly.

@rustbot
Copy link
Collaborator

rustbot commented Feb 16, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 16, 2024
@rustbot
Copy link
Collaborator

rustbot commented Feb 16, 2024

This PR modifies config.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@saethlin
Copy link
Member

Can you make this on by default in the compiler profile?

@Mark-Simulacrum
Copy link
Member

r=me on this change with or without the compiler profile change

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2024
@Noratrieb
Add rust.frame-pointers config option
09e6043 
This is very helpful for profiling. I've hacked this in many times, so
let's add it properly.
@rustbot
Copy link
Collaborator

rustbot commented Feb 18, 2024

This PR changes src/bootstrap/defaults/config.compiler.toml. If appropriate, please also update config.codegen.toml so the defaults are in sync.

This PR modifies src/bootstrap/defaults.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

This PR changes src/bootstrap/defaults/config.codegen.toml. If appropriate, please also update config.compiler.toml so the defaults are in sync.

@Noratrieb
Copy link
Member Author

with :3
@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Feb 18, 2024

📌 Commit 09e6043 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 18, 2024
@bors
Copy link
Contributor

bors commented Feb 19, 2024

⌛ Testing commit 09e6043 with merge eb1f279...

@bors
Copy link
Contributor

bors commented Feb 19, 2024

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing eb1f279 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 19, 2024
@bors bors merged commit eb1f279 into rust-lang:master Feb 19, 2024
12 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Feb 19, 2024
@Noratrieb Noratrieb deleted the fp branch February 19, 2024 11:46
@bors bors mentioned this pull request Feb 19, 2024
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (eb1f279): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.3% [-0.3%, -0.3%] 3
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.5% [3.5%, 3.6%] 2
Improvements ✅
(primary)		 -3.2% [-3.6%, -2.7%] 3
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -3.2% [-3.6%, -2.7%] 3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 640.916s -> 641.205s (0.05%)
Artifact size: 308.79 MiB -> 308.81 MiB (0.01%)

@nshyrei nshyrei mentioned this pull request Feb 26, 2024
Closed
@raoulstrackx raoulstrackx mentioned this pull request Feb 27, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 4, 2024
@matthiaskrgr
Rollup merge of rust-lang#121683 - fortanix:raoul/lvi_fixes, r=cuviper
3f7eced 
Fix LVI tests after frame pointers are enabled by default

rust-lang#121203 enables frame pointers by default. This affects LVI mitigations for the `x86_64-fortanix-unknown-sgx` target. LVI remained mitigated correctly, but the tests were too strict.

`@nshyrei` , `@jethrogb`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 4, 2024
@matthiaskrgr
Rollup merge of rust-lang#121683 - fortanix:raoul/lvi_fixes, r=cuviper
8886c31 
Fix LVI tests after frame pointers are enabled by default

rust-lang#121203 enables frame pointers by default. This affects LVI mitigations for the `x86_64-fortanix-unknown-sgx` target. LVI remained mitigated correctly, but the tests were too strict.

``@nshyrei`` , ``@jethrogb``
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2024
@rust-timer
Unrolled build for rust-lang#121683
ce2b6ed 
Rollup merge of rust-lang#121683 - fortanix:raoul/lvi_fixes, r=cuviper

Fix LVI tests after frame pointers are enabled by default

rust-lang#121203 enables frame pointers by default. This affects LVI mitigations for the `x86_64-fortanix-unknown-sgx` target. LVI remained mitigated correctly, but the tests were too strict.

``@nshyrei`` , ``@jethrogb``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Noratrieb @rustbot @saethlin @Mark-Simulacrum @bors @rust-timer