Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add diagnostic items for legacy numeric constants #121272

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Add diagnostic items for legacy numeric constants #121272

merged 1 commit into from
Feb 19, 2024

Conversation

pitaj
Copy link
Contributor

@pitaj pitaj commented Feb 18, 2024

@rustbot
Copy link
Collaborator

rustbot commented Feb 18, 2024

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 18, 2024
@Noratrieb
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 18, 2024

📌 Commit d9c1c73 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 19, 2024
@matthiaskrgr
Rollup merge of rust-lang#121272 - pitaj:diag_items-legacy_numeric_co…
07f0d04 
…nstants, r=Nilstrieb

Add diagnostic items for legacy numeric constants

For rust-lang/rust-clippy#12312
This was referenced Feb 19, 2024
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 19, 2024
@bors
Auto merge of rust-lang#121295 - matthiaskrgr:rollup-j2vffew, r=matth…
e29a153 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#119808 (Store core::str::CharSearcher::utf8_size as u8)
 - rust-lang#121032 (Continue reporting remaining errors instead of silently dropping them)
 - rust-lang#121041 (Add `Future` and `IntoFuture` to the 2024 prelude)
 - rust-lang#121230 (Extend Level API)
 - rust-lang#121272 (Add diagnostic items for legacy numeric constants)
 - rust-lang#121275 (add test for panicking attribute macros)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c2cc066 into rust-lang:master Feb 19, 2024
11 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Feb 19, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 19, 2024
@rust-timer
Unrolled build for rust-lang#121272
f5929b4 
Rollup merge of rust-lang#121272 - pitaj:diag_items-legacy_numeric_constants, r=Nilstrieb

Add diagnostic items for legacy numeric constants

For rust-lang/rust-clippy#12312
@pitaj pitaj mentioned this pull request Feb 20, 2024
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Feb 21, 2024
@Dylan-DPC
Rollup merge of rust-lang#121361 - pitaj:diag_items-legacy_numeric_co…
860ad7c 
…nstants, r=Nilstrieb

diagnostic items for legacy numeric modules

For rust-lang/rust-clippy#12312

Missed these in rust-lang#121272

r? `@Nilstrieb`
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 21, 2024
@rust-timer
Unrolled build for rust-lang#121361
9214050 
Rollup merge of rust-lang#121361 - pitaj:diag_items-legacy_numeric_constants, r=Nilstrieb

diagnostic items for legacy numeric modules

For rust-lang/rust-clippy#12312

Missed these in rust-lang#121272

r? `@Nilstrieb`
@pitaj pitaj mentioned this pull request Feb 27, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 27, 2024
@bors
Auto merge of rust-lang#121667 - pitaj:diag_items-legacy_numeric_cons…
1c28a2c 
…tants, r=Nilstrieb

syms for legacy numeric constants diag items

Missed these in rust-lang#121272 and rust-lang#121361, woops.

For rust-lang/rust-clippy#12312

r? `@Nilstrieb`
@pitaj pitaj mentioned this pull request Mar 10, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 10, 2024
@matthiaskrgr
Rollup merge of rust-lang#122271 - pitaj:diag_items-legacy_numeric_co…
58c9806 
…nstants, r=Nilstrieb

Fix legacy numeric constant diag items

- missed syms for usize/isize
- missed diag items on unsigned integers

For rust-lang/rust-clippy#12312

r? `@Nilstrieb`

Follow-up to rust-lang#121272, rust-lang#121361, rust-lang#121667
This should be the last one 🤞 Sorry!
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 10, 2024
@jhpratt
Rollup merge of rust-lang#122271 - pitaj:diag_items-legacy_numeric_co…
0a85274 
…nstants, r=Nilstrieb

Fix legacy numeric constant diag items

- missed syms for usize/isize
- missed diag items on unsigned integers

For rust-lang/rust-clippy#12312

r? ``@Nilstrieb``

Follow-up to rust-lang#121272, rust-lang#121361, rust-lang#121667
This should be the last one 🤞 Sorry!
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 10, 2024
@matthiaskrgr
Rollup merge of rust-lang#122271 - pitaj:diag_items-legacy_numeric_co…
9d03046 
…nstants, r=Nilstrieb

Fix legacy numeric constant diag items

- missed syms for usize/isize
- missed diag items on unsigned integers

For rust-lang/rust-clippy#12312

r? ```@Nilstrieb```

Follow-up to rust-lang#121272, rust-lang#121361, rust-lang#121667
This should be the last one 🤞 Sorry!
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 10, 2024
@rust-timer
Unrolled build for rust-lang#122271
170bb5a 
Rollup merge of rust-lang#122271 - pitaj:diag_items-legacy_numeric_constants, r=Nilstrieb

Fix legacy numeric constant diag items

- missed syms for usize/isize
- missed diag items on unsigned integers

For rust-lang/rust-clippy#12312

r? ```@Nilstrieb```

Follow-up to rust-lang#121272, rust-lang#121361, rust-lang#121667
This should be the last one 🤞 Sorry!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.
5 participants
@pitaj @rustbot @Noratrieb @bors @cuviper