stop leaking inference variables from snapshots #121365
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a revival of #100745. Right now we can very easily ICE when trying to use the returned values from
probe
andcommit_if_ok
.I closed that PR as this check detected issues but we didn't get any unexpected ICEs from this, so I thought:
nah, we just tend to not use the leaked inference vars in any way that causes ICEs. A slight change to
coercion
which I am working on separately did result in such an ICE.r? @compiler-errors