Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #121383

Merged
merged 18 commits into from
Feb 21, 2024
Merged

Rollup of 7 pull requests #121383

merged 18 commits into from
Feb 21, 2024

Commits on Feb 19, 2024

  1. Configuration menu
    Copy the full SHA
    6150991 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Configuration menu
    Copy the full SHA
    f68682f View commit details
    Browse the repository at this point in the history
  2. Make --verbose imply -Z write-long-types-to-disk=no

    When shortening the type it is necessary to take into account the
    `--verbose` flag, if it is activated, we must always show the entire
    type and not write it in a file.
    
    Fixes: rust-lang#119130
    ffmancera committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    e54ef0a View commit details
    Browse the repository at this point in the history
  3. Update panic message for missing //@ run-rustfix ui test suite when…

    … a .fixed file exists
    jieyouxu committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    ad14a22 View commit details
    Browse the repository at this point in the history
  4. Downgrade ambiguous_wide_pointer_comparisons suggestions to MaybeInco…

    …rrect
    
    It is possible to have more than one valid suggestion, which when
    applied together via rustfix causes the code to no longer compile.
    
    This is a temporary workaround; the real long term solution to these
    issues is to solve <rust-lang#53934>.
    jieyouxu committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    4d386d9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0195f21 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e35481f View commit details
    Browse the repository at this point in the history
  7. Convert delayed_bugs to bugs.

    I have a suspicion that quite a few delayed bug paths are impossible to
    reach, so I did an experiment.
    
    I converted every `delayed_bug` to a `bug`, ran the full test suite,
    then converted back every `bug` that was hit. A surprising number were
    never hit.
    
    The next commit will convert some more back, based on human judgment.
    nnethercote committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    010f394 View commit details
    Browse the repository at this point in the history
  8. Convert bugs back to delayed_bugs.

    This commit undoes some of the previous commit's mechanical changes,
    based on human judgment.
    nnethercote committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    2903bbb View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Configuration menu
    Copy the full SHA
    3da200d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    62e7414 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#121208 - nnethercote:delayed_bug-to-bug, r=…

    …lcnr
    
    Convert `delayed_bug`s to `bug`s.
    
    I have a suspicion that quite a few delayed bug paths are impossible to reach, so I did an experiment.
    
    I converted every `delayed_bug` to a `bug`, ran the full test suite, then converted back every `bug` that was hit. A surprising number were never hit.
    
    This is too dangerous to merge. Increased coverage (fuzzing or a crater run) would likely hit more cases. But it might be useful for people to look at and think about which paths are genuinely unreachable.
    
    r? `@ghost`
    Dylan-DPC authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    d5206c6 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#121288 - tshepang:make-expand-translatable,…

    … r=michaelwoerister
    
    make rustc_expand translatable
    
    these are the last of the easy ones
    Dylan-DPC authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    4840785 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#121304 - compiler-errors:ext, r=nnethercote

    Add docs for extension proc-macro
    
    r? nnethercote
    Dylan-DPC authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    94e459f View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#121328 - ffmancera:ff/verbose_long_type, r=…

    …compiler-errors
    
    Make --verbose imply -Z write-long-types-to-disk=no
    
    When shortening the type it is necessary to take into account the `--verbose` flag, if it is activated, we must always show the entire type and not write it in a file.
    
    Fixes: rust-lang#119130
    Dylan-DPC authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    4a205bb View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#121338 - jieyouxu:ambiguous_wide_pointer_co…

    …mparisons_suggestion, r=Nadrieril
    
    Downgrade ambiguous_wide_pointer_comparisons suggestions to MaybeIncorrect
    
    In certain cases like rust-lang#121330, it is possible to have more than one suggestion from the `ambiguous_wide_pointer_comparisons` lint (which before this PR are `MachineApplicable`). When this gets passed to rustfix, rustfix makes *multiple* changes according to the suggestions which result in incorrect code.
    
    This is a temporary workaround. The real long term solution to problems like these is to address <rust-lang#53934>.
    
    This PR also includes a drive-by edit to the panic message emitted by compiletest because "ui" test suite now uses `//`@`` directives.
    
    Fixes rust-lang#121330.
    Dylan-DPC authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    e10b3b8 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#121361 - pitaj:diag_items-legacy_numeric_co…

    …nstants, r=Nilstrieb
    
    diagnostic items for legacy numeric modules
    
    For rust-lang/rust-clippy#12312
    
    Missed these in rust-lang#121272
    
    r? `@Nilstrieb`
    Dylan-DPC authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    860ad7c View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#121375 - chenyukang:yukang-fix-tidy, r=albe…

    …rtlarsan68
    
    Print proper relative path for descriptive name check
    
    The `stripped_path` starts with `ui/...`, while we are mostly working in `rust` directory.
    print a relative path starting with `tests/ui/...` so that we can copy and use the path when renaming.
    
    Hardcoding the `tests` maybe not good style, but seems we have a lot of hardcoded `tests/..` paths in tidy check :(.
    Dylan-DPC authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    229108a View commit details
    Browse the repository at this point in the history