Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check that simd_insert/extract indices are in-bounds #121522

Merged
merged 2 commits into from
Feb 24, 2024
Merged

check that simd_insert/extract indices are in-bounds #121522

merged 2 commits into from
Feb 24, 2024

Conversation

RalfJung
Copy link
Member

Fixes #77477
r? @oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 23, 2024
@rustbot
Copy link
Collaborator

rustbot commented Feb 23, 2024

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

The Miri subtree was changed

cc @rust-lang/miri

@RalfJung RalfJung force-pushed the insert-extract-boundscheck branch from e2ad39f to f714984 Compare February 23, 2024 18:36
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@RalfJung RalfJung force-pushed the insert-extract-boundscheck branch from f714984 to 134e2b2 Compare February 23, 2024 18:44
@oli-obk
Copy link
Contributor

oli-obk commented Feb 23, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 23, 2024

📌 Commit 134e2b2 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2024
@bors
Copy link
Contributor

bors commented Feb 23, 2024

⌛ Testing commit 134e2b2 with merge 627d20d...

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 23, 2024
@bors
Auto merge of rust-lang#121522 - RalfJung:insert-extract-boundscheck,…
627d20d 
… r=oli-obk

check that simd_insert/extract indices are in-bounds

Fixes rust-lang#77477
r? `@oli-obk`
@bors
Copy link
Contributor

bors commented Feb 23, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 23, 2024
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
2
Image input checksum 1c43300698300c5cf94386814ed77f2940acce09689b051da2abc327d16e65b7efbef34ace3339880f0ba3871b962b49895e9356fb7734ce6e4cb052eef354ce
##[group]Building docker image for armhf-gnu
Docker version 24.0.8, build e0dfb46
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang-ci&client_id=docker&offline_token=true&service=ghcr.io": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.

@RalfJung
Copy link
Member Author

@bors retry Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang-ci&client_id=docker&offline_token=true&service=ghcr.io": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 24, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 24, 2024
@bors
Auto merge of rust-lang#121549 - matthiaskrgr:rollup-1hvu3lb, r=matth…
381d699 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#121435 (Account for RPITIT in E0310 explicit lifetime constraint suggestion)
 - rust-lang#121490 (Rustdoc: include crate name in links for local primitives)
 - rust-lang#121520 (delay cloning of iterator items)
 - rust-lang#121522 (check that simd_insert/extract indices are in-bounds)
 - rust-lang#121531 (Ignore less tests in debug builds)
 - rust-lang#121539 (compiler/rustc_target/src/spec/base/apple/tests.rs: Avoid unnecessary large move)
 - rust-lang#121542 (update stdarch)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b87a713 into rust-lang:master Feb 24, 2024
11 of 12 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Feb 24, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 24, 2024
@rust-timer
Unrolled build for rust-lang#121522
1e843a6 
Rollup merge of rust-lang#121522 - RalfJung:insert-extract-boundscheck, r=oli-obk

check that simd_insert/extract indices are in-bounds

Fixes rust-lang#77477
r? `@oli-obk`
@RalfJung RalfJung deleted the insert-extract-boundscheck branch February 25, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.

simd_insert and simd_extract allow garbage data
5 participants
@RalfJung @rustbot @rust-log-analyzer @oli-obk @bors