Skip to content

Conversation

RalfJung
Copy link
Member

Also add some comments to abi_can_unwind to explain what happens.

r? @nbdd0121 Cc @BatmanAoD

@rustbot
Copy link
Collaborator

rustbot commented Feb 24, 2024

Failed to set assignee to nbdd0121: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 24, 2024
@rustbot
Copy link
Collaborator

rustbot commented Feb 24, 2024

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@RalfJung
Copy link
Member Author

r? @BatmanAoD then maybe?

@rustbot
Copy link
Collaborator

rustbot commented Feb 24, 2024

Failed to set assignee to BatmanAoD: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@RalfJung
Copy link
Member Author

Ah, sorry, I thought someone must have made you reviewer by now oops.
r? compiler

@BatmanAoD
Copy link
Member

Ah, sorry, I thought someone must have made you reviewer by now oops.

I don't actually know very much at all about rustc internals, and haven't read much of the code.

@bors

This comment was marked as resolved.

@RalfJung RalfJung force-pushed the ffi-unwind-intrinsics branch from 4280b36 to 54d024e Compare February 27, 2024 06:10
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with typo fix

@RalfJung RalfJung force-pushed the ffi-unwind-intrinsics branch from 54d024e to f5c80dc Compare February 27, 2024 11:28
@RalfJung
Copy link
Member Author

@bors r=davidtwco

@bors
Copy link
Collaborator

bors commented Feb 27, 2024

📌 Commit f5c80dc has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2024
@bors
Copy link
Collaborator

bors commented Feb 27, 2024

⌛ Testing commit f5c80dc with merge b6e4299...

@bors
Copy link
Collaborator

bors commented Feb 27, 2024

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing b6e4299 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 27, 2024
@bors bors merged commit b6e4299 into rust-lang:master Feb 27, 2024
@rustbot rustbot added this to the 1.78.0 milestone Feb 27, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b6e4299): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.7% [-1.7%, -1.7%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.8% [2.8%, 2.8%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 650.65s -> 650.523s (-0.02%)
Artifact size: 311.12 MiB -> 311.11 MiB (-0.00%)

@RalfJung RalfJung deleted the ffi-unwind-intrinsics branch February 28, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants