Fix bad span for explicit lifetime suggestions

[ShoyuVanilla]

Fixes #121267

Current explicit lifetime suggestions are not showing correct spans for some lifetimes - e.g. elided lifetime generic parameters;

This should be done correctly regarding elided lifetime kind like the following code

rust/compiler/rustc_resolve/src/late/diagnostics.rs

Lines 3015 to 3044 in 43fdd49

	let mut spans_suggs: Vec<_> = Vec::new();
	let build_sugg = |lt: MissingLifetime| match lt.kind {
	MissingLifetimeKind::Underscore => {
	debug_assert_eq!(lt.count, 1);
	(lt.span, existing_name.to_string())
	}
	MissingLifetimeKind::Ampersand => {
	debug_assert_eq!(lt.count, 1);
	(lt.span.shrink_to_hi(), format!("{existing_name} "))
	}
	MissingLifetimeKind::Comma => {
	let sugg: String = std::iter::repeat([existing_name.as_str(), ", "])
	.take(lt.count)
	.flatten()
	.collect();
	(lt.span.shrink_to_hi(), sugg)
	}
	MissingLifetimeKind::Brackets => {
	let sugg: String = std::iter::once("<")
	.chain(
	std::iter::repeat(existing_name.as_str()).take(lt.count).intersperse(", "),
	)
	.chain([">"])
	.collect();
	(lt.span.shrink_to_hi(), sugg)
	}
	};
	for &lt in &lifetime_refs {
	spans_suggs.push(build_sugg(lt));
	}

[rustbot]

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[TaKO8Ki]

Sorry for the late review. I left one suggestion.

[estebank]

Please squash your three commits into one.

[ShoyuVanilla]

Please squash your three commits into one.

Thanks! I've squash rebased onto the recent revision 😄

[TaKO8Ki]

@bors r+

[bors]

📌 Commit c270a42 has been approved by TaKO8Ki

It is now in the queue for this repository.

[bors]

⌛ Testing commit c270a42 with merge 6e1f7b5...

[bors]

☀️ Test successful - checks-actions
Approved by: TaKO8Ki
Pushing 6e1f7b5 to master...

[rust-timer]

Finished benchmarking commit (6e1f7b5): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.0%, -2.0%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.782s -> 669.528s (-0.04%)
Artifact size: 312.72 MiB -> 312.72 MiB (-0.00%)