Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #121627

Merged
merged 15 commits into from
Feb 26, 2024
Merged

Rollup of 5 pull requests #121627

merged 15 commits into from
Feb 26, 2024

Commits on Feb 23, 2024

  1. Configuration menu
    Copy the full SHA
    36f298c View commit details
    Browse the repository at this point in the history
  2. Simplify existing code for setting filecheck flags

    This removes a version check for LLVM >=13, and specifies prefixes as a series
    of independent `--check-prefix` flags instead of a single `--check-prefixes`.
    Zalathar committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    1e432dd View commit details
    Browse the repository at this point in the history
  3. Allow tests to specify a //@ filecheck-flags: header

    Any flags specified here will be passed to LLVM's `filecheck` tool, in tests
    that use that tool.
    Zalathar committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    baec307 View commit details
    Browse the repository at this point in the history
  4. Move existing coverage codegen tests into a subdirectory

    This makes room for migrating over `tests/run-make/instrument-coverage`,
    without increasing the number of top-level items in the codegen test directory.
    Zalathar committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    c1889b5 View commit details
    Browse the repository at this point in the history
  5. Convert tests/run-make/instrument-coverage to an ordinary codegen test

    This test was already very close to being an ordinary codegen test, except that
    it needed some extra logic to set a few variables based on (target) platform
    characteristics.
    
    Now that we have support for `//@ filecheck-flags:`, we can instead set those
    variables using the normal test revisions mechanism.
    Zalathar committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    0c19c63 View commit details
    Browse the repository at this point in the history
  6. Remove unhelpful DEFINE_INTERNAL from filecheck flags

    This define was copied over from the run-make version of the test, but doesn't
    seem to serve any useful purpose.
    Zalathar committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    e56cc84 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2024

  1. Don't unnecessarily change SIGPIPE disposition in unix_sigpipe tests

    In `auxiliary/sigpipe-utils.rs`, all we want to know is the current
    `SIGPIPE` disposition. We should not change it. So use `libc::sigaction`
    instead of `libc::signal`. That way we can also remove the code that
    restores it.
    Enselic committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    f5b9eaf View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2024

  1. Configuration menu
    Copy the full SHA
    3af67bb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    edda2a7 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Configuration menu
    Copy the full SHA
    8bccceb View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#120656 - Zalathar:filecheck-flags, r=wesley…

    …wiser
    
    Allow tests to specify a `//@ filecheck-flags:` header
    
    This allows individual codegen/assembly/mir-opt tests to pass extra flags to the LLVM `filecheck` tool as needed.
    
    ---
    
    The original motivation was noticing that `tests/run-make/instrument-coverage` was very close to being an ordinary codegen test, except that it needs some extra logic to set up platform-specific variables to be passed into filecheck.
    
    I then saw the comment in `verify_with_filecheck` indicating that a `filecheck-flags` header might be useful for other purposes as well.
    GuillaumeGomez authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    0e08be5 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#120840 - HTGAzureX1212:HTGAzureX1212/unicod…

    …e-identifier-types, r=fmease,Manishearth
    
    Split Diagnostics for Uncommon Codepoints: Add Individual Identifier Types
    
    This pull request further modifies the `uncommon_codepoints` lint, adding the individual identifier types of `Technical`, `Not_NFKC`, `Exclusion` and `Limited_Use` to the diagnostic message.
    
    Example rendered diagnostic:
    ```
    error: identifier contains a Unicode codepoint that is not used in normalized strings: 'ij'
      --> $DIR/lint-uncommon-codepoints.rs:6:4
       |
    LL | fn dijkstra() {}
       |    ^^^^^^^
       = note: this character is included in the Not_NFKC Unicode general security profile
    ```
    
    Second step of rust-lang#120228.
    GuillaumeGomez authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    91d337d View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#121554 - Enselic:sigaction, r=oli-obk

    Don't unnecessarily change `SIGPIPE` disposition in `unix_sigpipe` tests
    
    In `auxiliary/sigpipe-utils.rs`, all we want to know is the current `SIGPIPE` disposition. We should not change it. So use `libc::sigaction` instead of `libc::signal`. That way we can also remove the code that restores it.
    
    Part of rust-lang#97889.
    GuillaumeGomez authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    5bd9092 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#121590 - GuillaumeGomez:rustdoc-js-changed,…

    … r=notriddle
    
    Correctly handle if rustdoc JS script hash changed
    
    It's something that annoyed me for quite some time: I have nightly docs open (for both std and compiler). And often, I don't look at the page for some days. Then when I come back to it, I make a search... except nothing happens. Took me a while to figure out that it was because the hash of one of the JS files we load for the search (either `search.js` or `search-index.js`) was updated in the meantime, preventing the search to be done. To go around it, I added to press `ENTER` to make the form submitted (which would reload the same page but with the correct hashes this time and the search being run).
    
    r? `@notriddle`
    GuillaumeGomez authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    a1593a6 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#121620 - nnethercote:fix-even-more-121208-f…

    …allout, r=lcnr
    
    Fix more rust-lang#121208 fallout (round 3)
    
    rust-lang#121208 converted lots of delayed bugs to bugs. Unsurprisingly, there were a few invalid conversion found via fuzzing.
    
    r? `@lcnr`
    GuillaumeGomez authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    76f303d View commit details
    Browse the repository at this point in the history