-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: enhancing x test tidy
with lint checks
#121696
Conversation
x test tidy
with lint checks
This comment has been minimized.
This comment has been minimized.
Signed-off-by: onur-ozkan <work@onurozkan.dev>
0b4b993
to
05b8bd6
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
I think this should be a separate step from |
I was thinking to perform this check only on the modified crates for non-CI environments, so the cost wouldn't be high for developers. |
Or, maybe I could include
But to do that, we'll need to merge #121543 first and that is currently blocked by rust-lang/backtrace-rs#586. |
I will follow that approach in #122883, closing this. |
As an initial step aiming to include only simple crates, likely tools.
r? ghost