Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pattern analysis: Don't panic when encountering unexpected constructor #121735

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

Nadrieril
Copy link
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 28, 2024
@compiler-errors
Copy link
Member

Hmm... Can you explain a bit more about why rust-analyzer is encountering this but rustc doesn't?

My only concern is that this filtering-out may instead hide bugs in the pattern lowering by silently filtering out patterns rather than exploding like it is now.

@Nadrieril
Copy link
Member Author

Nadrieril commented Feb 28, 2024

The problem is that rust-analyzer regularly runs match checking on matches that aren't type-correct. They try to avoid that but their detection has holes.

I'm not too worried about hiding bugs this way, because if an unexpected constructor shows up rustc should explode in Constructor::is_covered_by. rust-analyzer has a non-explody path in that function instead.

@compiler-errors
Copy link
Member

ok thanks for the info

@bors r+ rollup

@compiler-errors
Copy link
Member

hello bors

@bors r+ rollup

@compiler-errors
Copy link
Member

@bors ping 🤔

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 28, 2024

📌 Commit 12b991d has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 28, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 28, 2024
…r=compiler-errors

pattern analysis: Don't panic when encountering unexpected constructor

Tiny PR to fix rust-lang/rust-analyzer#16656

r? `@compiler-errors`
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 29, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#110543 (Make `ReentrantLock` public)
 - rust-lang#121689 ([rustdoc] Prevent inclusion of whitespace character after macro_rules ident)
 - rust-lang#121724 (Use `LitKind::Err` for malformed floats)
 - rust-lang#121735 (pattern analysis: Don't panic when encountering unexpected constructor)
 - rust-lang#121743 (Opportunistically resolve regions when processing region outlives obligations)

Failed merges:

 - rust-lang#121326 (Detect empty leading where clauses on type aliases)
 - rust-lang#121416 (Improve error messages for generics with default parameters)
 - rust-lang#121669 (Count stashed errors again)
 - rust-lang#121723 (Two diagnostic things)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit eca6a24 into rust-lang:master Feb 29, 2024
22 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Feb 29, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 29, 2024
Rollup merge of rust-lang#121735 - Nadrieril:no-panic-on-type-error, r=compiler-errors

pattern analysis: Don't panic when encountering unexpected constructor

Tiny PR to fix rust-lang/rust-analyzer#16656

r? ``@compiler-errors``
@Nadrieril Nadrieril deleted the no-panic-on-type-error branch February 29, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

thread 'Worker' panicked at ra-ap-rustc_pattern_analysis-0.37.0/src/constructor.rs:947:63
4 participants