Rollup of 10 pull requests #121790
Merged
Rollup of 10 pull requests #121790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some crosslinking among `std::env` pages. Also add aliases to help anyone searching for `PATH`.
Modified according to rust-lang/compiler-team#505.
Closes rust-lang#118009 This commit adds unwind safety to Condvar. Previously, only select platforms implemented unwind safety through auto traits. Known by this committer: Linux was unwind safe, but Mac and Windows are not before this change.
This commit: - Moves the ICE file create/open outside the loop. (Redoing it on every loop iteration works, but is really weird.) - Moves the explanatory note emission above the loop, which removes the need for the `enumerate` call. - Introduces a `decorate` local.
Line 190 contains unpaired parentheses.
…nieu Increase visibility of `join_path` and `split_paths` Add some crosslinking among `std::env` pages to make it easier to discover `join_paths` and `split_paths`. Also add aliases to help anyone searching for `PATH`.
Have `String` use `SliceIndex` impls from `str` This PR simplifies the implementation of `Index` and `IndexMut` on `String`, and in the process enables indexing `String` by any user types that implement `SliceIndex<str>`. Similar to rust-lang#47832 r? libs Not sure if this warrants a crater run.
… r=oli-obk Two diagnostic things Two minor improvements to diagnostics-related things. r? ``@RalfJung``
…_20240228, r=lcnr Changing some attributes to only_local. Modified according to rust-lang/compiler-team#505. r? ``@lcnr``
…t-deeply-norm, r=lcnr Deeply normalize obligations in `refining_impl_trait` We somewhat awkwardly use semantic comparison when checking the `refining_impl_trait` lint. This relies on us being able to normalize bounds eagerly to avoid cases where an unnormalized alias is not considered equal to a normalized alias. Since `normalize` in the new solver is a noop, let's use `deeply_normalize` instead. r? lcnr cc ``@tmandry,`` this should fix your bug lol
…manieu Restore the standard library review rotation to its former glory This adds 7 reviewers to the standard library review rotation, bringing the total back up to 10 people. Specifically: * On the main rotation: ``@cuviper`` ``@Mark-Simulacrum`` ``@m-ou-se`` ``@Amanieu`` ``@Nilstrieb`` ``@workingjubilee`` ``@joboet`` ``@jhpratt`` * For `core` only: ``@scottmcm`` * For `std` only: ``@ChrisDenton`` For everyone pinged here, please confirm that you are happy to be added to the review rotation.
Implement unwind safety for Condvar on all platforms Closes rust-lang#118009 This commit adds unwind safety consistency to Condvar. Previously, only select platforms implemented unwind safety through auto traits. Known by this committer: On Linux, `Condvar` implemented `UnwindSafe` but on Mac and Windows, it did not. This change changes the implementation from auto to explicit. In rust-lang#118009, it was suggested that the platform differences were a bug and that a simple PR could address this. In trying to determine the best information to put in the `#[stable]` attribute, it [was suggested](rust-lang#121690 (comment)) I copy the stability information from the previous unwind safety implementations.
Fix typo in `rustc_passes/messages.ftl`
Line 190 contains unpaired parentheses:
```
passes_doc_cfg_hide_takes_list =
`#[doc(cfg_hide(...)]` takes a list of attributes
```
The `#[doc(cfg_hide(...)]` contains unpaired parentheses. This PR changes it to `#[doc(cfg_hide(...))]`, which made the parentheses paired.
Document potential memory leak in unbounded channel Follow up on rust-lang#121646.
Remove unused diagnostic struct Detected by rust-lang#121752
|
@bors r+ rollup=never p=10 |
rustbot
added
A-meta
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: d3d145ea1c In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (71a7b66): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 650.923s -> 650.304s (-0.10%) |
|
Results appear to be random noise. @rustbot label pref-regression-triaged |
|
I disagree, the Cargo change looks to be both above any noise floor and does not show signs of reverting. However, it's not significant enough (given limit to just Cargo) to investigate further. |
Mark-Simulacrum
added
the
perf-regression-triaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
join_pathandsplit_paths#119748 (Increase visibility ofjoin_pathandsplit_paths)StringuseSliceIndeximpls fromstr#120291 (HaveStringuseSliceIndeximpls fromstr)refining_impl_trait#121745 (Deeply normalize obligations inrefining_impl_trait)rustc_passes/messages.ftl#121777 (Fix typo inrustc_passes/messages.ftl)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup