-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix close_read_wakes_up
test
#122095
fix close_read_wakes_up
test
#122095
Conversation
I do strongly disagree with my past self for enabling this test. As I recall at the time, there were a number of tests that were simply disabled on Windows instead of fixing the bug that caused the failure and when bugs were fixed, tests weren't re-enabled. It seems I was a bit, let's say "over enthusiastic", about re-enabling tests. In any case, let's see what CI has to say. @bors r+ rollup=iffy |
☀️ Test successful - checks-actions |
Finished benchmarking commit (48a15aa): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 650.027s -> 650.646s (0.10%) |
On windows,
shutdown
does not interruptread
, even though we document that it does (see #121594).The
close_read_wakes_up
test has a race condition and only passes on windows if theshutdown
happens before theread
. This PR ignores the test on windows adds a sleep to make it more likely that theread
happens before theshutdown
and the test actually tests what it is supposed to test on other platforms.I'm submitting this before any docs changes, so that we can find out on what platforms
shutdown
actually works as documented.r? @ChrisDenton