Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #122139

Merged
merged 27 commits into from
Mar 7, 2024
Merged

Commits on Mar 4, 2024

  1. add test for assoc type mismatch in supertrait

    Lukas Markeffsky committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    6fa58be View commit details
    Browse the repository at this point in the history
  2. adjust obligation spans for super projections

    Lukas Markeffsky committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    189e784 View commit details
    Browse the repository at this point in the history
  3. rename ast_* to hir_* in wfcheck

    Lukas Markeffsky committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    443c816 View commit details
    Browse the repository at this point in the history
  4. suppress fulfillment errors for super projections

    Lukas Markeffsky committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    aa55f6d View commit details
    Browse the repository at this point in the history
  5. address review feedback

    Lukas Markeffsky committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    6bd970d View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Configuration menu
    Copy the full SHA
    f415379 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8e45d0f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ee1c691 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9891d6a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    52bc7ce View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Configuration menu
    Copy the full SHA
    850cc34 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bf9782d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1a2bc11 View commit details
    Browse the repository at this point in the history
  4. Set RustcDocs to only run on host

    `./x dist` currently crashes when cross compiling. Add the fix described
    by @catamorphism in rust-lang#110071.
    
    Fixes rust-lang#110071
    tgross35 committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    9d9e78e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    71d35d8 View commit details
    Browse the repository at this point in the history
  6. improve debug logging

    Lukas Markeffsky committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    db48b93 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9669934 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#121863 - lukas-code:silence-mismatched-supe…

    …r-projections, r=lcnr
    
    silence mismatched types errors for implied projections
    
    Currently, if a trait bound is not satisfied, then we suppress any errors for the trait's supertraits not being satisfied, but still report errors for super projections not being satisfied.
    
    For example:
    ```rust
    trait Super {
        type Assoc;
    }
    trait Sub: Super<Assoc = ()> {}
    ```
    Before this PR, if `T: Sub` is not satisfied, then errors for `T: Super` are suppressed, but errors for `<T as Super>::Assoc == ()` are still shown. This PR makes it so that errors about super projections not being satisfied are also suppressed.
    
    The errors are only suppressed if the span of the trait obligation matches the span of the super predicate obligation to avoid silencing error that are not related. This PR removes some differences between the spans of supertraits and super projections to make the suppression work correctly.
    
    This PR fixes the majority of the diagnostics fallout when making `Thin` a supertrait of `Sized` (in a future PR).
    cc rust-lang#120354 (comment)
    cc `@lcnr`
    GuillaumeGomez authored Mar 7, 2024
    Configuration menu
    Copy the full SHA
    0e37648 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#122043 - Y-Nak:move-early-binder, r=lcnr

    Apply `EarlyBinder` only to `TraitRef` in `ImplTraitHeader`
    
    Resolves rust-lang#121852
    
    This PR
    1. Moves `EarlyBinder` to `TraitRef` inside `ImplTraitHeader`,
    2. Changes visibility of `coherence::builtin::check_trait` to `pub(super)` from `pub` as it seems not being re-exported from the `coherence` module.
    GuillaumeGomez authored Mar 7, 2024
    Configuration menu
    Copy the full SHA
    e52c541 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#122066 - mu001999:clean, r=oli-obk

    Add proper cfgs for struct HirIdValidator used only with debug-assert
    
    See rust-lang#122065 (comment).
    I think it's due to rust-lang#121752.
    GuillaumeGomez authored Mar 7, 2024
    Configuration menu
    Copy the full SHA
    f1fb720 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#122104 - RalfJung:rust, r=ChrisDenton

    Rust is a proper name: rust → Rust
    
    I only went over the library where it might be user-visible -- I noticed this in the `time` docs.
    GuillaumeGomez authored Mar 7, 2024
    Configuration menu
    Copy the full SHA
    6b04518 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#122110 - WaffleLapkin:miri-temp, r=RalfJung

    Make `x t miri` respect `MIRI_TEMP`
    
    (I don't want to override `TMPDIR`, as that might affect other things)
    
    r? ``@RalfJung``
    GuillaumeGomez authored Mar 7, 2024
    Configuration menu
    Copy the full SHA
    d7106d2 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#122114 - saethlin:cant-find-crate-spam, r=W…

    …affleLapkin
    
    Make not finding core a fatal error
    
    Similar to rust-lang#120472, this prevents terminal spam. In particular, it makes the good diagnostic visible when you try to use a target that's not installed.
    GuillaumeGomez authored Mar 7, 2024
    Configuration menu
    Copy the full SHA
    66a062a View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#122115 - clubby789:cancel-recoverr, r=compi…

    …ler-errors
    
    Cancel parsing ever made during recovery
    
    Fixes rust-lang#122112
    
    It would be nice if diagnostics from recovery were automatically cancelled... 🤔
    GuillaumeGomez authored Mar 7, 2024
    Configuration menu
    Copy the full SHA
    9bda4e4 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#122123 - compiler-errors:object-trait-alias…

    …-bounds, r=oli-obk
    
    Don't require specifying unrelated assoc types when trait alias is in `dyn` type
    
    Object types must specify the associated types for all of the principal trait ref's supertraits. However, we weren't doing elaboration properly, so we incorrectly errored with erroneous suggestions to specify associated types that were unrelated to that principal trait ref. To fix this, use proper supertrait elaboration when expanding trait aliases in `conv_object_ty_poly_trait_ref`.
    
    **NOTE**: Please use the ignore-whitespace option when reviewing. This only touches a handful of lines.
    
    r? oli-obk or please feel free to reassign.
    
    Fixes rust-lang#122118
    GuillaumeGomez authored Mar 7, 2024
    Configuration menu
    Copy the full SHA
    bb582c6 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#122126 - workingjubilee:every-os-in-the-wor…

    …ld-belongs-to-unix, r=ChrisDenton
    
    Fix `tidy --bless` on  ̶X̶e̶n̶i̶x̶ Windows
    
    As reported in rust-lang#120628 (comment) the requested `tidy --bless` implementation didn't take into account the fact that earlier the linting code canonicalized things to use the OS path separator. This makes it so that the path separator is always rewritten back as '/', which should fix the variance there.
    
    r? ``@ChrisDenton``
    GuillaumeGomez authored Mar 7, 2024
    Configuration menu
    Copy the full SHA
    d03d9a4 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#122129 - tgross35:rustcdocs-host-only, r=on…

    …ur-ozkan
    
    Set `RustcDocs` to only run on host
    
    `./x dist` currently crashes when cross compiling. Add the fix described by `@catamorphism` in rust-lang#110071.
    
    Fixes rust-lang#110071
    GuillaumeGomez authored Mar 7, 2024
    Configuration menu
    Copy the full SHA
    ce9a6ad View commit details
    Browse the repository at this point in the history