Adds support for working with URL Paths #12231
Merged
+115
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is sometimes useful to parse just the path portion of a URL (path, query string and fragment) rather than the entire URL.
|
cc @SimonSapin |
|
The code that’s in Also, because the spec is written with the client’s point of view in mind, the result of "parsing" is percent-encoded, ready to be sent on the network. Your tests show percent-decoded results, which I guess is what you want on the server-side. |
|
@wycats, would rust-url solve your needs? If so, perhaps we should delete |
|
This is in a self-contained library for now, so I think it's fine to add in until we merge rust-url. |
bors
added a commit
that referenced
this pull request
Feb 19, 2014
It is sometimes useful to parse just the path portion of a URL (path, query string and fragment) rather than the entire URL. In theory I could have made Url embed a Path, but that would be a breaking change and I assume that Servo uses this API. I would be happy to update the PR to embed Path in Url if that's what people wanted.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
…, r=jonas-schievink fix: fix "X is not a valid punct" panic with floats in macros Should fix rust-lang/rust-analyzer#12211
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 26, 2024
Add y21 to the review rotation rust-lang/team#1342 r? `@ghost,` when you're ready to be added to the rotation ``@bors` r+` this `@y21` changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is sometimes useful to parse just the path portion of a URL (path,
query string and fragment) rather than the entire URL.
In theory I could have made Url embed a Path, but that would be a
breaking change and I assume that Servo uses this API. I would be
happy to update the PR to embed Path in Url if that's what people
wanted.