Consolidate WF for aliases

[compiler-errors]

Make RPITs/TAITs/weak (type) aliases/projections all enforce:

1. their nominal predicates
2. their args are WF

This possibly does extra work, but is also nice for consistency sake.

r? lcnr

[compiler-errors]

@bors try

[bors]

⌛ Trying commit b16ff29 with merge eb761a9...

[compiler-errors]

@rust-timer queue

[bors]

☀️ Try build successful - checks-actions
Build commit: eb761a9 (eb761a90cb473450ad47653f743c60864a1daebd)

[rust-timer]

Finished benchmarking commit (eb761a9): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.8%	[0.6%, 4.9%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.7%, -2.3%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 652.28s -> 651.369s (-0.14%)
Artifact size: 309.94 MiB -> 310.01 MiB (0.02%)

[lcnr]

r=me

additional thought

compute_projection_args is just alias_ty.visit_with(with), but less performant as it emmits nested goals. Might be worth it to try and change it in this PR as well.

[compiler-errors]

compute_projection_args is just alias_ty.visit_with(with), but less performant as it emmits nested goals. Might be worth it to try and change it in this PR as well.

It also filters args w/ escaping bound vars.

[compiler-errors]

@bors r=lcnr rollup

[bors]

📌 Commit 04524c8 has been approved by lcnr

It is now in the queue for this repository.

[compiler-errors]

actually why did i roll that up

@bors rollup=never

(useful for bisection i guess)

[lcnr]

It also filters args w/ escaping bound vars.

yeah, so by eagerly recursing we filter slightly fewer types, e.g. we start emitting an error for for<'a> Alias<([str], &'a u32)>. However, this is desirable :>

[compiler-errors]

I'd rather crater that in a separate PR, and perhaps also throw in other cases (e.g. trait refs) where this is being done in WF

[compiler-errors]

#122501

[bors]

⌛ Testing commit 04524c8 with merge 1ca424c...

[bors]

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 1ca424c to master...

[rust-timer]

Finished benchmarking commit (1ca424c): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.0%	[0.6%, 1.5%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.3%	[1.1%, 3.6%]	15
Regressions ❌ (secondary)	2.4%	[0.5%, 3.7%]	56
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.3%	[1.1%, 3.6%]	15

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.355s -> 669.777s (0.06%)
Artifact size: 311.47 MiB -> 311.40 MiB (-0.02%)