Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Exploit Mitigations PG to triagebot.toml #122429

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Add Exploit Mitigations PG to triagebot.toml #122429

merged 1 commit into from
Mar 14, 2024

Conversation

rcvalle
Copy link
Member

@rcvalle rcvalle commented Mar 13, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Mar 13, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the A-meta Area: Issues & PRs about the rust-lang/rust repository itself label Mar 13, 2024
@rustbot
Copy link
Collaborator

rustbot commented Mar 13, 2024

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 13, 2024
@rcvalle rcvalle force-pushed the rust-triagebot-add-exploit-mitigations-pg branch from 221f959 to 0e0888b Compare March 13, 2024 11:01
compiler-errors
compiler-errors reviewed Mar 13, 2024
View reviewed changes
triagebot.toml Outdated
@@ -642,6 +661,51 @@ cc = ["@nnethercote"]
message = "Changes to the size of AST and/or HIR nodes."
cc = ["@nnethercote"]

[mentions."compiler/rustc_symbol_mangling/src/typeid"]
cc = ["@project-exploit-mitigations", "@rcvalle"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't function the way you expect it will, since @project-exploit-mitigations is not a valid github @ -- it should be written like @rust-lang/project-exploit-mitigations.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, why are you pinging yourself explicitly? You should be pinged as a member of the group.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks for pointing it out! I'm listing myself there explicitly for when the project group finishes the work (since it's temporary), I'd like to continue to be pinged, but let me know if you prefer me to remove it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any fixed having been made

@rcvalle rcvalle force-pushed the rust-triagebot-add-exploit-mitigations-pg branch 2 times, most recently from 2aaf445 to b878ad2 Compare March 13, 2024 15:22
compiler-errors
compiler-errors reviewed Mar 13, 2024
View reviewed changes
triagebot.toml Outdated
@@ -642,6 +661,51 @@ cc = ["@nnethercote"]
message = "Changes to the size of AST and/or HIR nodes."
cc = ["@nnethercote"]

[mentions."compiler/rustc_symbol_mangling/src/typeid"]
cc = [" @rust-lang/project-exploit-mitigations", "@rcvalle"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cc = [" @rust-lang/project-exploit-mitigations", "@rcvalle"]
cc = ["@rust-lang/project-exploit-mitigations", "@rcvalle"]

There's a space here 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 😅. Thanks a lot, Michael!

@rcvalle
Add Exploit Mitigations PG to triagebot.toml
533ddf9 
Add autolabels and mentions for the Exploit Mitigations PG to
triagebot.toml.
@rcvalle rcvalle force-pushed the rust-triagebot-add-exploit-mitigations-pg branch from b878ad2 to 533ddf9 Compare March 13, 2024 15:24
@wesleywiser
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 13, 2024

📌 Commit 533ddf9 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 13, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 13, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 13, 2024
@bors
Auto merge of rust-lang#122454 - matthiaskrgr:rollup-xbmufdc, r=matth…
06dfdb0 
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#122422 (compiletest: Allow `only-unix` in test headers)
 - rust-lang#122424 (fix: typos)
 - rust-lang#122425 (Increase timeout for new bors bot)
 - rust-lang#122426 (Fix StableMIR `WrappingRange::is_full` computation)
 - rust-lang#122429 (Add Exploit Mitigations PG to triagebot.toml)
 - rust-lang#122430 (Generate link to `Local` in `hir::Let` documentation)
 - rust-lang#122434 (pattern analysis: rename a few types)
 - rust-lang#122437 (pattern analysis: remove `MaybeInfiniteInt::JustAfterMax`)
 - rust-lang#122438 (Safe Transmute: Require that source referent is smaller than destination)
 - rust-lang#122442 (extend docs of -Zprint-mono-items)
 - rust-lang#122449 (Delay a bug for stranded opaques)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 14, 2024
@bors
Auto merge of rust-lang#122454 - matthiaskrgr:rollup-xbmufdc, r=matth…
6f3eb1c 
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#122422 (compiletest: Allow `only-unix` in test headers)
 - rust-lang#122424 (fix: typos)
 - rust-lang#122425 (Increase timeout for new bors bot)
 - rust-lang#122426 (Fix StableMIR `WrappingRange::is_full` computation)
 - rust-lang#122429 (Add Exploit Mitigations PG to triagebot.toml)
 - rust-lang#122430 (Generate link to `Local` in `hir::Let` documentation)
 - rust-lang#122434 (pattern analysis: rename a few types)
 - rust-lang#122437 (pattern analysis: remove `MaybeInfiniteInt::JustAfterMax`)
 - rust-lang#122438 (Safe Transmute: Require that source referent is smaller than destination)
 - rust-lang#122442 (extend docs of -Zprint-mono-items)
 - rust-lang#122449 (Delay a bug for stranded opaques)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c6acc47 into rust-lang:master Mar 14, 2024
11 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Mar 14, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 14, 2024
@rust-timer
Unrolled build for rust-lang#122429
d1bdb20 
Rollup merge of rust-lang#122429 - rcvalle:rust-triagebot-add-exploit-mitigations-pg, r=wesleywiser

Add Exploit Mitigations PG to triagebot.toml
@rcvalle rcvalle deleted the rust-triagebot-add-exploit-mitigations-pg branch April 22, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.
6 participants
@rcvalle @rustbot @wesleywiser @bors @compiler-errors @Mark-Simulacrum