Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't trigger unused_qualifications on global paths #122435

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Don't trigger unused_qualifications on global paths #122435

merged 1 commit into from
Mar 19, 2024

Conversation

jieyouxu
Copy link
Member

Fixes #122374.

@rustbot
Copy link
Collaborator

rustbot commented Mar 13, 2024

r? @michaelwoerister

rustbot has assigned @michaelwoerister.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 13, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu jieyouxu force-pushed the unused_qualifications_global_paths branch from a7b37fa to fd7f617 Compare March 13, 2024 14:36
@c410-f3r
Copy link
Contributor

In regards to the linked issue, Default is already included in the prelude so technically the full path is indeed unnecessary.

cc @petrochenkov since you are involved in #121708

@michaelwoerister
Copy link
Member

In regards to the linked issue, Default is already included in the prelude so technically the full path is indeed unnecessary.

There seems to be a diagnostics design/policy question involved here.

r? diagnostics

@kpreid kpreid mentioned this pull request Mar 14, 2024
Open
@bors

This comment was marked as resolved.

Sign in to view
@jieyouxu
Don't trigger unused_qualifications on global paths
85bad8d 
# Conflicts:
#	tests/ui/lint/lint-qualification.stderr
@jieyouxu jieyouxu force-pushed the unused_qualifications_global_paths branch from fd7f617 to 85bad8d Compare March 15, 2024 15:00
@compiler-errors
Copy link
Member

r? petrochenkov

@petrochenkov
Copy link
Contributor

This change makes behavior of unused_qualifications more conservative and closer to its previous version, thus addressing some false positives from incorrectly written proc macros.
@bors r+

@bors
Copy link
Contributor

bors commented Mar 19, 2024

📌 Commit 85bad8d has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 19, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 19, 2024
@bors
Auto merge of rust-lang#122735 - matthiaskrgr:rollup-pgb1s90, r=matth…
e760daa 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#122435 (Don't trigger `unused_qualifications` on global paths)
 - rust-lang#122556 (Extend format arg help for simple tuple index access expression)
 - rust-lang#122634 (compiletest: Add support for `//@ aux-bin: foo.rs`)
 - rust-lang#122677 (Fix incorrect mutable suggestion information for binding in ref pattern.)
 - rust-lang#122691 (Fix ICE: `global_asm!()` Don't Panic When Unable to Evaluate Constant)
 - rust-lang#122695 (Change only_local to a enum type.)
 - rust-lang#122717 (Ensure stack before parsing dot-or-call)
 - rust-lang#122719 (Ensure nested statics have a HIR node to prevent various queries from ICEing)
 - rust-lang#122720 ([doc]:fix error code example)
 - rust-lang#122724 (add test for casting pointer to union with unsized tail)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 489c2e9 into rust-lang:master Mar 19, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Mar 19, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 19, 2024
@rust-timer
Unrolled build for rust-lang#122435
78c3e8d 
Rollup merge of rust-lang#122435 - jieyouxu:unused_qualifications_global_paths, r=petrochenkov

Don't trigger `unused_qualifications` on global paths

Fixes rust-lang#122374.
@jieyouxu jieyouxu deleted the unused_qualifications_global_paths branch March 19, 2024 20:06
@kpreid
Copy link
Contributor

kpreid commented Apr 28, 2024

This PR addresses a diagnostics regression (#122519) from stable to what-is-about-to-be-stable (we are currently in the pre-release testing period for 1.78 and the beta branch is for 1.79). Therefore, I believe this should be considered for backporting, and as a "stable" backport rather than "beta" backport.

@rustbot label +stable-nominated

@rustbot
Copy link
Collaborator

rustbot commented Apr 28, 2024

Error: Label stable-nominated can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@compiler-errors compiler-errors added the stable-nominated Nominated for backporting to the compiler in the stable channel. label Apr 28, 2024
@oli-obk oli-obk added the stable-accepted Accepted for backporting to the compiler in the stable channel. label Apr 29, 2024
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Apr 29, 2024
Merged
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.79.0, 1.78.0 Apr 29, 2024
@Mark-Simulacrum Mark-Simulacrum removed the stable-nominated Nominated for backporting to the compiler in the stable channel. label Apr 29, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 29, 2024
@bors
Auto merge of rust-lang#124517 - Mark-Simulacrum:stable-next, r=Mark-…
9b00956 
…Simulacrum

[stable] 1.78 (round 2)

This backports "Don't trigger `unused_qualifications` on global paths" (rust-lang#122435).

r? `@Mark-Simulacrum`
@davidzeng0 davidzeng0 mentioned this pull request May 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. stable-accepted Accepted for backporting to the compiler in the stable channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.

unused_qualifications warns about global paths