Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #122475

Closed
wants to merge 12 commits into from

Commits on Mar 9, 2024

  1. Avoid closing invalid handles

    dylni committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    a82587c View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Configuration menu
    Copy the full SHA
    dd0f41f View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Improve Step docs

    CAD97 committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    c527ec7 View commit details
    Browse the repository at this point in the history
  2. Make incremental sessions identity no longer depend on the crate name…

    …s provided by source code
    Zoxc committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    12cd322 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. fixes rust-lang#121331

    surechen committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    1a81a94 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    da8a8c9 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#119029 - dylni:avoid-closing-invalid-handle…

    …s, r=ChrisDenton
    
    Avoid closing invalid handles
    
    Documentation for [`HandleOrInvalid`] has this note:
    
    > If holds a handle other than `INVALID_HANDLE_VALUE`, it will close the handle on drop.
    
    Documentation for [`HandleOrNull`] has this note:
    
    > If this holds a non-null handle, it will close the handle on drop.
    
    Currently, both will call `CloseHandle` on their invalid handles as a result of using `OwnedHandle` internally, contradicting the above paragraphs. This PR adds destructors that match the documentation.
    
    ``@rustbot`` label A-io O-windows T-libs
    
    [`HandleOrInvalid`]: https://doc.rust-lang.org/std/os/windows/io/struct.HandleOrInvalid.html
    [`HandleOrNull`]: https://doc.rust-lang.org/std/os/windows/io/struct.HandleOrNull.html
    matthiaskrgr committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    060e364 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#121764 - Zoxc:incr-sess-no-source, r=oli-obk

    Make incremental sessions identity no longer depend on the crate names provided by source code
    
    This makes incremental sessions identity no longer depend on the crate names provided by source code, implementing
    rust-lang/compiler-team#726.
    
    r? ```@oli-obk```
    matthiaskrgr committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    8d1aeed View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#122373 - surechen:fix_121331, r=petrochenkov

    Fix the conflict problem between the diagnostics fixes of lint `unnecessary_qualification`  and  `unused_imports`
    
    fixes rust-lang#121331
    
    For an `item` that triggers lint unnecessary_qualification, if the `use item` which imports this item is also trigger unused import, fixing the two lints at the same time may lead to the problem that the `item` cannot be found.
    This PR will avoid reporting lint unnecessary_qualification when conflict occurs.
    
    r? `@petrochenkov`
    matthiaskrgr committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    a9c4480 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#122406 - compiler-errors:next-solver-asynck…

    …ind-wf, r=lcnr
    
    Fix WF for `AsyncFnKindHelper` in new trait solver
    
    `to_opt_closure_kind` ICEs when it sees placeholders... so don't do that
    
    no test b/c I'm too lazy to write a no-core test for this, but I could be convinced otherwise
    
    r? lcnr
    matthiaskrgr committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    78a7f9b View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#122421 - CAD97:step-trait-docs, r=jhpratt

    Improve `Step` docs
    
    It [came up on urlo](https://users.rust-lang.org/t/implement-trait-step-in-1-76-0/108204?u=cad97) that the unstable reason string isn't helpful, so just remove it; there's nothing meaningful to add here.
    
    Also makes a couple drive-by improvements to the method docs -- removes incorrect references, changes `forward_checked`'s invariant formulation to match `backward_checked`'s, and adds a helpful corollary that `step_unchecked(a, 0)` is always safe.
    matthiaskrgr committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    6085739 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#122471 - RalfJung:const-eval-span, r=oli-obk

    preserve span when evaluating mir::ConstOperand
    
    This lets us show to the user where they were using the faulty const (which can be quite relevant when generics are involved).
    
    I wonder if we should change "erroneous constant encountered" to something like "the above error was encountered while evaluating this constant" or so, to make this more similar to what the collector emits when showing a "backtrace" of where things get monomorphized? It seems a bit strange to rely on the order of emitted diagnostics for that but it seems the collector already [does that](https://github.com/rust-lang/rust/blob/da8a8c9223722e17cc0173ce9490076b4a6d263d/compiler/rustc_monomorphize/src/collector.rs#L472-L475).
    matthiaskrgr committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    cde2274 View commit details
    Browse the repository at this point in the history