libstd: Implement some convenience methods on new vectors #12253
+221
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1138,6 +1138,7 @@ impl<'a,T> ImmutableVector<'a, T> for &'a [T] { | |||
| } | |||
|
|
|||
| fn map<U>(&self, f: |t: &T| -> U) -> ~[U] { | |||
|
|
|||
There was a problem hiding this comment.
What is this blank line?
|
@pcwalton this needs rebase |
|
rebased, r? @brson |
|
|
||
| #[inline] | ||
| pub fn map<U>(&self, f: |t: &T| -> U) -> Vec<U> { | ||
| self.iter().map(f).collect() |
There was a problem hiding this comment.
Do we want to keep using this definition of map on the new vectors? As I understand it, map on ~[T] is considered deprecated for a long time, as iterators allow one to express the same, and if we ever get Iterable it would conflict anyway.
There was a problem hiding this comment.
If it makes landing the ~[] removable easier, keep it: someone else can remove it later if necessary.
bors
added a commit
that referenced
this pull request
Feb 21, 2014
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
feat: Add binding mode inlay hints 
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 26, 2024
…eds-usize, r=Manishearth fix: ICE when array index exceeds usize fixes rust-lang#12253 This PR fixes ICE in `indexing_slicing` as it panics when the index of the array exceeds `usize`. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brson