Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #122635

Closed
wants to merge 6 commits into from
Closed

Fix typos #122635

wants to merge 6 commits into from

Conversation

omahs
Copy link
Contributor

@omahs omahs commented Mar 17, 2024

Fix typos

@rustbot
Copy link
Collaborator

rustbot commented Mar 17, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 17, 2024
@rustbot
Copy link
Collaborator

rustbot commented Mar 17, 2024

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

ytmimi
ytmimi reviewed Mar 17, 2024
View reviewed changes
src/tools/rustfmt/CHANGELOG.md
Copy link
Contributor

@ytmimi ytmimi Mar 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! When you have a moment could you please revert all the rustfmt changes and instead submit those separately to the rust-lang/rustfmt repo. The rustfmt team would rather these types of changes not be made directly in the rust-lang/rust repo.

@omahs
Copy link
Contributor Author

omahs commented Mar 17, 2024

@ytmimi Thanks for the quick review, I checked rust-lang/rustfmt and it's already been fixed. Closing this for #122639

@omahs omahs closed this Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytmimi ytmimi ytmimi left review comments

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@omahs @rustbot @ytmimi @oli-obk