Remove some only- clauses from mir-opt tests

[saethlin]

Derived from #122295

Many of these tests were originally codegen tests, and MIR is more trivially portable than LLVM IR. We simply don't need to restrict the platform in most cases.

r? Nadrieril

[Nadrieril]

nice!

@bors r+ rollup

[bors]

📌 Commit 6828f0c has been approved by Nadrieril

It is now in the queue for this repository.

[Nadrieril]

ah wait, this could fail in rollup since bors tries more targets than PR CI does

@bors rollup=maybe

[matthiaskrgr]

@bors rollup=iffy since queue is basically empty right now

[bors]

⌛ Testing commit 6828f0c with merge 19acca7...

[bors]

💔 Test failed - checks-actions

[Nadrieril]

Well, that explains it :D

[Nadrieril]

The targets list for --bless is currently somewhat arbitrary. We could choose only targets with asm support? (and change that one test to run under these targets)

[saethlin]

The bless list already only contains targets with asm support; the test failed because we tried to run a test that needs assembly support on a target that doesn't have it.

I've made the change that I think makes the most sense here, but I'm going to run the test-various Docker image locally before I re-apply your approval.

[saethlin]

@bors r=Nadrieril

[bors]

📌 Commit 68f284f has been approved by Nadrieril

It is now in the queue for this repository.

[Nadrieril]

Nice, TIL about needs-asm-support

[saethlin]

Me too. I found it by grepping through all the other compiletest directives used in the mir-opt tests.

[workingjubilee]

cute.

rust/src/tools/compiletest/src/header/needs.rs

Lines 9 to 21 in d31b6fb

	// Note thet we intentionally still put the needs- prefix here to make the file show up when
	// grepping for a directive name, even though we could technically strip that.
	let needs = &[
	Need {
	name: "needs-asm-support",
	condition: config.has_asm_support(),
	ignore_reason: "ignored on targets without inline assembly support",
	},
	Need {
	name: "needs-sanitizer-support",
	condition: cache.sanitizer_support,
	ignore_reason: "ignored on targets without sanitizers support",
	},

[bors]

⌛ Testing commit 68f284f with merge 91b87c4...

[bors]

☀️ Test successful - checks-actions
Approved by: Nadrieril
Pushing 91b87c4 to master...

[rust-timer]

Finished benchmarking commit (91b87c4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.1%	[-4.6%, -3.7%]	2
Improvements ✅ (secondary)	-2.4%	[-3.5%, -0.9%]	4
All ❌✅ (primary)	-4.1%	[-4.6%, -3.7%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 668.321s -> 669.426s (0.17%)
Artifact size: 312.76 MiB -> 312.79 MiB (0.01%)