Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay interning errors to after validation #122684

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Delay interning errors to after validation #122684

merged 6 commits into from
Apr 18, 2024

Commits on Apr 17, 2024

  1. Validate nested static items

    @oli-obk
    oli-obk committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    8c9cba2 View commit details
    Browse the repository at this point in the history

  2. Run the "is this static mutable" logic the same way as in `in_mutable… 

    …_memory`
    @oli-obk
    oli-obk committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    d87e963 View commit details
    Browse the repository at this point in the history

  3. Deduplicate logic for checking the mutability of allocations

    @oli-obk
    oli-obk committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    140c9e1 View commit details
    Browse the repository at this point in the history

  4. Simplify alloc id mutability check

    @oli-obk
    oli-obk committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    8b2a4f8 View commit details
    Browse the repository at this point in the history

  5. Validate before reporting interning errors. 

    validation produces much higher quality errors and already handles most of the cases
    @oli-obk
    oli-obk committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    77fe9f0 View commit details
    Browse the repository at this point in the history

  6. Use less fragile error handling

    @oli-obk
    oli-obk committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    126dcc6 View commit details
    Browse the repository at this point in the history