-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conditionally ignore fatal diagnostic in the SilentEmitter #122737
conditionally ignore fatal diagnostic in the SilentEmitter #122737
Conversation
r? @davidtwco rustbot has assigned @davidtwco. Use |
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt |
This comment has been minimized.
This comment has been minimized.
This change is primarily meant to allow rustfmt to ignore all diagnostics when using the `SilentEmitter`. Back in PR 121301 the `SilentEmitter` was shared between rustc and rustfmt. This changed rustfmt's behavior from ignoring all diagnostic to emitting fatal diagnostics. These changes allow rustfmt to maintain it's previous behaviour when using the SilentEmitter, while allowing rustc code to still emit fatal diagnostics.
43f1e58
to
d49d136
Compare
Good find, seems like rustc and rustfmt have different interpretations of a "silent" emitter 🤔 on the rustfmt side we will definitely need a completely silent emitter vs. a silent-unless-fatal one |
@bors r+ |
…diagnostic, r=davidtwco conditionally ignore fatal diagnostic in the SilentEmitter This change is primarily meant to allow rustfmt to ignore all diagnostics when using the `SilentEmitter`. Back in rust-lang#121301 the `SilentEmitter` was shared between rustc and rustfmt. This changed rustfmt's behavior from ignoring all diagnostic to emitting fatal diagnostics, which lead to rust-lang/rustfmt#6109. These changes allow rustfmt to maintain its previous behaviour when using the `SilentEmitter`, while allowing rustc code to still emit fatal diagnostics.
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#122737 (conditionally ignore fatal diagnostic in the SilentEmitter) - rust-lang#122757 (Fixed the `private-dependency` bug) - rust-lang#122886 (add test for rust-lang#90192) - rust-lang#122937 (Unbox and unwrap the contents of `StatementKind::Coverage`) - rust-lang#122949 (Add a regression test for rust-lang#117310) - rust-lang#122962 (Track run-make-support lib in common inputs stamp) - rust-lang#122977 (Rename `Arguments::as_const_str` to `as_statically_known_str`) - rust-lang#122983 (Fix build failure on ARM/AArch64/PowerPC/RISC-V FreeBSD/NetBSD) - rust-lang#122984 (panic-in-panic-hook: formatting a message that's just a string is risk-free) - rust-lang#122992 (std::thread: refine available_parallelism for solaris/illumos.) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#122737 (conditionally ignore fatal diagnostic in the SilentEmitter) - rust-lang#122757 (Fixed the `private-dependency` bug) - rust-lang#122886 (add test for rust-lang#90192) - rust-lang#122937 (Unbox and unwrap the contents of `StatementKind::Coverage`) - rust-lang#122949 (Add a regression test for rust-lang#117310) - rust-lang#122962 (Track run-make-support lib in common inputs stamp) - rust-lang#122977 (Rename `Arguments::as_const_str` to `as_statically_known_str`) - rust-lang#122983 (Fix build failure on ARM/AArch64/PowerPC/RISC-V FreeBSD/NetBSD) - rust-lang#122984 (panic-in-panic-hook: formatting a message that's just a string is risk-free) - rust-lang#122992 (std::thread: refine available_parallelism for solaris/illumos.) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#122737 - ytmimi:conditionally_ignore_fatal_diagnostic, r=davidtwco conditionally ignore fatal diagnostic in the SilentEmitter This change is primarily meant to allow rustfmt to ignore all diagnostics when using the `SilentEmitter`. Back in rust-lang#121301 the `SilentEmitter` was shared between rustc and rustfmt. This changed rustfmt's behavior from ignoring all diagnostic to emitting fatal diagnostics, which lead to rust-lang/rustfmt#6109. These changes allow rustfmt to maintain its previous behaviour when using the `SilentEmitter`, while allowing rustc code to still emit fatal diagnostics.
…diagnostic, r=davidtwco conditionally ignore fatal diagnostic in the SilentEmitter This change is primarily meant to allow rustfmt to ignore all diagnostics when using the `SilentEmitter`. Back in rust-lang#121301 the `SilentEmitter` was shared between rustc and rustfmt. This changed rustfmt's behavior from ignoring all diagnostic to emitting fatal diagnostics, which lead to rust-lang/rustfmt#6109. These changes allow rustfmt to maintain its previous behaviour when using the `SilentEmitter`, while allowing rustc code to still emit fatal diagnostics.
…diagnostic, r=davidtwco conditionally ignore fatal diagnostic in the SilentEmitter This change is primarily meant to allow rustfmt to ignore all diagnostics when using the `SilentEmitter`. Back in rust-lang#121301 the `SilentEmitter` was shared between rustc and rustfmt. This changed rustfmt's behavior from ignoring all diagnostic to emitting fatal diagnostics, which lead to rust-lang/rustfmt#6109. These changes allow rustfmt to maintain its previous behaviour when using the `SilentEmitter`, while allowing rustc code to still emit fatal diagnostics.
This change is primarily meant to allow rustfmt to ignore all diagnostics when using the
SilentEmitter
. Back in #121301 theSilentEmitter
was shared between rustc and rustfmt. This changed rustfmt's behavior from ignoring all diagnostic to emitting fatal diagnostics, which lead to rust-lang/rustfmt#6109.These changes allow rustfmt to maintain its previous behaviour when using the
SilentEmitter
, while allowing rustc code to still emit fatal diagnostics.