Implement macro-based deref!() syntax for deref patterns #122793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in exhaustiveness checking cc @Nadrieril Some changes occurred in match lowering cc @Nadrieril Some changes occurred in match checking cc @Nadrieril |
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
deref-pat-syntax
branch
from
7d50e10 to
f32e8f5
Compare
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
compiler-errors
changed the title
6 tasks
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
deref-pat-syntax
branch
from
f32e8f5 to
33292c3
Compare
This comment has been minimized.
This comment has been minimized.
|
Didn't we want to expand built-in macros to |
|
Oh, yeah, that's easier. I didn't even know about that. |
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
deref-pat-syntax
branch
from
adc5217 to
b5e10de
Compare
|
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt |
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
deref-pat-syntax
branch
from
b5e10de to
72be1e3
Compare
clubby789
reviewed
Mar 21, 2024
ytmimi
reviewed
Mar 21, 2024
|
👍 r=me with the two changes requested by others (when the other PR lands) |
Stop using `box PAT` syntax for deref patterns, as it's misleading and also causes their semantics being tangled up.
compiler-errors
force-pushed
the
deref-pat-syntax
branch
from
72be1e3 to
a4db3ff
Compare
|
Good to go I think @bors r=Nadrieril |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 21, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#122402 (Make `#[diagnostic::on_unimplemented]` format string parsing more robust) - rust-lang#122644 (pattern analysis: add a custom test harness) - rust-lang#122733 (Strip placeholders from hidden types before remapping generic parameter) - rust-lang#122752 (Interpolated cleanups) - rust-lang#122771 (add some comments to hir::ModuleItems) - rust-lang#122793 (Implement macro-based deref!() syntax for deref patterns) - rust-lang#122810 (Remove `target_override`) - rust-lang#122827 (Remove unnecessary braces from `bug`/`span_bug`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 21, 2024
Rollup merge of rust-lang#122793 - compiler-errors:deref-pat-syntax, r=Nadrieril Implement macro-based deref!() syntax for deref patterns Stop using `box PAT` syntax for deref patterns, and instead use a perma-unstable macro. Blocked on rust-lang#122222 r? `@Nadrieril`
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop using
box PATsyntax for deref patterns, and instead use a perma-unstable macro.Blocked on #122222
r? @Nadrieril